fix creating debugging comment for HTML comment (#4567)

tanhauhau · web-flow · commit a0749f6adb7f · 2020-03-22T08:08:32.000-04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Svelte changelog
 
+## Unreleased
+
+* Fix attaching of JS debugging comments to HTML comments ([#4565](https://github.com/sveltejs/svelte/issues/4565))
+
 ## 3.20.1
 
 * Fix compiler regression with slots ([#4562](https://github.com/sveltejs/svelte/issues/4562))
diff --git a/src/compiler/compile/render_dom/wrappers/shared/create_debugging_comment.ts b/src/compiler/compile/render_dom/wrappers/shared/create_debugging_comment.ts
@@ -24,7 +24,7 @@ export default function create_debugging_comment(
 			while (source[d] !== '>') d += 1;
 			d += 1;
 		}
-	} else if (node.type === 'Text') {
+	} else if (node.type === 'Text' || node.type === 'Comment') {
 		d = node.end;
 	} else {
 		// @ts-ignore
diff --git a/test/runtime/samples/component-slot-fallback-4/Inner.svelte b/test/runtime/samples/component-slot-fallback-4/Inner.svelte
@@ -0,0 +1,3 @@
+<slot name="a"><!-- placeholder--></slot>
+<slot name="b"><!-- placeholder--> </slot>
+<slot name="c"><!-- placeholder--> foobar </slot>
diff --git a/test/runtime/samples/component-slot-fallback-4/_config.js b/test/runtime/samples/component-slot-fallback-4/_config.js
@@ -0,0 +1,5 @@
+export default {
+	html: `
+	foobar
+	`,
+};
diff --git a/test/runtime/samples/component-slot-fallback-4/main.svelte b/test/runtime/samples/component-slot-fallback-4/main.svelte
@@ -0,0 +1,5 @@
+<script>
+	import Inner from "./Inner.svelte";
+</script>
+
+<Inner></Inner>

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ export default function create_debugging_comment(`
`24`	`24`	`while (source[d] !== '>') d += 1;`
`25`	`25`	`d += 1;`
`26`	`26`	`}`
`27`		`- } else if (node.type === 'Text') {`
	`27`	`+ } else if (node.type === 'Text' \|\| node.type === 'Comment') {`
`28`	`28`	`d = node.end;`
`29`	`29`	`} else {`
`30`	`30`	`// @ts-ignore`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+<slot name="a"><!-- placeholder--></slot>`
	`2`	`+<slot name="b"><!-- placeholder--> </slot>`
	`3`	`+<slot name="c"><!-- placeholder--> foobar </slot>`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +export default {
 +	html: `
 +	foobar
 +	`,
 +};