Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte-check breaking changes v4 #2243

Closed
dummdidumm opened this issue Jan 2, 2024 · 4 comments · Fixed by #2453
Closed

svelte-check breaking changes v4 #2243

dummdidumm opened this issue Jan 2, 2024 · 4 comments · Fixed by #2453

Comments

@dummdidumm
Copy link
Member

dummdidumm commented Jan 2, 2024

Loose collection of things we should do for v4:

  • make TypeScript a peer dependency
  • Possibly chokidar v4 is out by then and we should check whether or not to switch to it. By the looks of it it will be ESM only, so we need change our output to be ESM, too. But that sounds like a good thing to do either way; and likely harmless since svelte-check is meant to be used as a command line tool where that doesn't matter.
  • Check which minimum Node version to support. Probably 18

Issues to take a closer look at:

Timing:

  • after we investigated Volar? no
  • with Svelte 5? no, shorty before it
@benmccann
Copy link
Member

Potentially #2391

@dummdidumm
Copy link
Member Author

  • Possibly chokidar v4 is out by then and we should check whether or not to switch to it. By the looks of it it will be ESM only, so we need change our output to be ESM, too. But that sounds like a good thing to do either way; and likely harmless since svelte-check is meant to be used as a command line tool where that doesn't matter.
  • Checks which minimum Node version to support. Probably 18

@dummdidumm
Copy link
Member Author

#2420

@dummdidumm
Copy link
Member Author

dummdidumm commented Jul 30, 2024

Idea for svelte-preprocess (would address #2391):

  • keep it in language-server, but load it through await with try-catch
  • make it external in rollup build config in svelte-check, which means the fallback doesn't kick in when using svelte-check

PR's related to major:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants