From e65eda9fc267150ade052d786967890fddceaad7 Mon Sep 17 00:00:00 2001
From: "S. Elliott Johnson" <sejohnson@torchcloudconsulting.com>
Date: Thu, 16 Jan 2025 13:53:13 -0700
Subject: [PATCH] chore: Resolve some random TODOs

---
 .../adapter-static/test/apps/prerendered/package.json    | 2 +-
 packages/adapter-static/test/apps/spa/package.json       | 2 +-
 packages/kit/src/core/postbuild/prerender.js             | 2 +-
 packages/kit/src/exports/node/index.js                   | 3 +--
 .../src/routes/load/unchanged-parent/+layout.svelte      | 9 ---------
 .../apps/basics/src/routes/load/unchanged/+layout.svelte | 9 ---------
 6 files changed, 4 insertions(+), 23 deletions(-)
 delete mode 100644 packages/kit/test/apps/basics/src/routes/load/unchanged-parent/+layout.svelte
 delete mode 100644 packages/kit/test/apps/basics/src/routes/load/unchanged/+layout.svelte

diff --git a/packages/adapter-static/test/apps/prerendered/package.json b/packages/adapter-static/test/apps/prerendered/package.json
index c040f5a6b7e2..b142360b34de 100644
--- a/packages/adapter-static/test/apps/prerendered/package.json
+++ b/packages/adapter-static/test/apps/prerendered/package.json
@@ -1,5 +1,5 @@
 {
-	"name": "~TODO~",
+	"name": "adapter-static-test-prerendered",
 	"version": "0.0.1",
 	"private": true,
 	"scripts": {
diff --git a/packages/adapter-static/test/apps/spa/package.json b/packages/adapter-static/test/apps/spa/package.json
index a13507f14424..df963a81240e 100644
--- a/packages/adapter-static/test/apps/spa/package.json
+++ b/packages/adapter-static/test/apps/spa/package.json
@@ -1,5 +1,5 @@
 {
-	"name": "~TODO~",
+	"name": "adapter-static-test-spa",
 	"version": "0.0.1",
 	"private": true,
 	"scripts": {
diff --git a/packages/kit/src/core/postbuild/prerender.js b/packages/kit/src/core/postbuild/prerender.js
index d2c1954c04df..aede70341b57 100644
--- a/packages/kit/src/core/postbuild/prerender.js
+++ b/packages/kit/src/core/postbuild/prerender.js
@@ -317,7 +317,7 @@ async function prerender({ hash, out, manifest_path, metadata, verbose, env }) {
 				const { pathname, search, hash } = new URL(href, 'http://localhost');
 
 				if (search) {
-					// TODO warn that query strings have no effect on statically-exported pages
+					log.warn(`Query parameters in ${href} will have no affect on prerendering`);
 				}
 
 				if (hash) {
diff --git a/packages/kit/src/exports/node/index.js b/packages/kit/src/exports/node/index.js
index c4def8f89cd0..f2f54a106bda 100644
--- a/packages/kit/src/exports/node/index.js
+++ b/packages/kit/src/exports/node/index.js
@@ -146,8 +146,7 @@ export async function setResponse(res, response) {
 				key,
 				key === 'set-cookie'
 					? set_cookie_parser.splitCookiesString(
-							// This is absurd but necessary, TODO: investigate why
-							/** @type {string}*/ (response.headers.get(key))
+							value
 						)
 					: value
 			);
diff --git a/packages/kit/test/apps/basics/src/routes/load/unchanged-parent/+layout.svelte b/packages/kit/test/apps/basics/src/routes/load/unchanged-parent/+layout.svelte
deleted file mode 100644
index fff80915ef60..000000000000
--- a/packages/kit/test/apps/basics/src/routes/load/unchanged-parent/+layout.svelte
+++ /dev/null
@@ -1,9 +0,0 @@
-<!-- TODO remove this file post-https://github.com/sveltejs/kit/issues/5967 -->
-<slot />
-
-<ul>
-	<li><a href="/load/unchanged-parent/isolated/a">/load/unchanged-parent/isolated/a</a></li>
-	<li><a href="/load/unchanged-parent/isolated/b">/load/unchanged-parent/isolated/b</a></li>
-	<li><a href="/load/unchanged-parent/uses-parent/a">/load/unchanged-parent/uses-parent/a</a></li>
-	<li><a href="/load/unchanged-parent/uses-parent/b">/load/unchanged-parent/uses-parent/b</a></li>
-</ul>
diff --git a/packages/kit/test/apps/basics/src/routes/load/unchanged/+layout.svelte b/packages/kit/test/apps/basics/src/routes/load/unchanged/+layout.svelte
deleted file mode 100644
index 5a9f45ce3ac4..000000000000
--- a/packages/kit/test/apps/basics/src/routes/load/unchanged/+layout.svelte
+++ /dev/null
@@ -1,9 +0,0 @@
-<!-- TODO remove this file post-https://github.com/sveltejs/kit/issues/5967 -->
-<slot />
-
-<ul>
-	<li><a href="/load/unchanged/isolated/a">/load/unchanged/isolated/a</a></li>
-	<li><a href="/load/unchanged/isolated/b">/load/unchanged/isolated/b</a></li>
-	<li><a href="/load/unchanged/uses-parent/a">/load/unchanged/uses-parent/a</a></li>
-	<li><a href="/load/unchanged/uses-parent/b">/load/unchanged/uses-parent/b</a></li>
-</ul>