-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuestionImagePickerModel
contains irrelevant properties related to special choices
#9152
Comments
Hi @budang, We will fix this issue. If users do not want to select any image item, they can simply leave the question unselected. Or, you can use a separate question to represent these None and Don't Know items. @RomanTsukanov, these settings should not be available for an Image Picker. |
QuestionImagePickerModel
contains irrelevant properties related to special choices
In order to remove the unsupported properties from the Image Picker class, we need to refactor our code by putting the properties into a separate class or mixin. |
Hello @JaneSjs and @RomanTsukanov, Thanks for your responses. Regarding these statements:
For sake of discussion, while I understand that an image is assigned to these items, the For example, if the question is "Select all images that have pictures of cats" but all the pictures are only of dogs, then a "None" option/value would be appropriate here. This would also be simpler/more elegant than splitting it into a two-part question. For choices with an invalid image URL, SurveyJS provides a default graphic and makes the choice unselectable; perhaps SurveyJS can do something similar for This is just an idea/suggestion and not an explicit request. I do not have a personal opinion on whether to implement this suggestion or just do the code refactor. Thanks! |
Describe the bug
Per the documentation (e.g., React), ImagePicker question types have the
showNoneItem
property which can be set to display aNone
choice item. Even if this attribute is set totrue
, no such choice item gets displayed. The same happens forshowDontKnowItem
,showRefuseItem
, andshowOtherItem
properties.https://surveyjs.io/form-library/documentation/api-reference/image-picker-question-model#showNoneItem
Steps to reproduce
json.js
Expected behavior
If
showNoneItem
is set totrue
, aNone
choice item should appear with the default text or the custom text set innoneText
. The same should happen ifshowDontKnowItem
,showRefuseItem
, andshowOtherItem
are set totrue
.Screenshots
https://plnkr.co/edit/QkTCehNe9t1qf9tJ
Please complete the following information:
Additional context
n/a
The text was updated successfully, but these errors were encountered: