Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some (!) keyboard shortcuts do not work as expected in CLAP in REAPER #7985

Open
Rundraster opened this issue Mar 1, 2025 · 6 comments
Open
Labels
Bug Report Item submitted using the Bug Report template CLAP Issues related to CLAP plugin format

Comments

@Rundraster
Copy link

Hello there,
this is my first contribution here.
Of course i've used the search function here, and was surprised that this seems to be no issue already.

By using the CLAP version of Surge XT, some (!) keyboard shortcuts do not work directly. Not until i activate "Send all keyboard input to plug-in" in plug-in options as a workaround.
Is that the recommended way to work with the CLAP version in Reaper?
In the VST3 version they work instantly, without that workaround.

In CLAP, these shortcuts DO work also instantly here:
Ctrl+F
Alt+F
Alt+A
Alt+O
Alt+K
"+"
"-"
Shift+"+"
Shift+"-"
Shift+Left
Shift+Right
F1
F12

The reason could be that these are not bound by Reaper itself here, so no override appears, EXCEPT for the keys "+" and "-". They ARE bound with Reaper actions. Hm...

Version: Surge XT 1.3.4.f7b97c6
Build Info: 2024-08-11 @ 16:02:24 on 'fv-az292-728/pipeline' with 'MSVC-19.40.33813.0' using JUCE 7.0.12
System Info: Windows 64-bit CLAP on Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz, 8 GB RAM
Host: Reaper @ 48000 Hz
Processing Block: 32 samples

Windows 10
Reaper 7.33
Bitness: 64

@Rundraster Rundraster added the Bug Report Item submitted using the Bug Report template label Mar 1, 2025
@baconpaul
Copy link
Collaborator

I wonder if we need to apply surge-synthesizer/sst-clap-helpers@d4e0fbe to the clap juce helpers

I’m traveling with Mac only right now but can look at that this week sometime

@mkruselj
Copy link
Collaborator

mkruselj commented Mar 2, 2025

CLAP doesn't have keyboard handling the way VST3 does. So it is going to behave differently.

@baconpaul
Copy link
Collaborator

yeah but that juce hack/trick basically gets around al the keyboard handling.

reaper doesn't implement the vst3 keyboard handling logic at all - it seems only cubase live and s1 do - and so the difference between reaper vst3 and reaper clap is almost definitely the application of that juce trick which basically snags the windows event loop, and which in surge will be on in the vst3

@mkruselj
Copy link
Collaborator

mkruselj commented Mar 2, 2025

Noted!

@baconpaul
Copy link
Collaborator

Another “would haven’t have found without six sines” gem!

@Rundraster
Copy link
Author

Oh cool. Thanks for noting and caring!

@mkruselj mkruselj added the CLAP Issues related to CLAP plugin format label Mar 9, 2025
@mkruselj mkruselj added this to the Surge XT 1.4.0 milestone Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template CLAP Issues related to CLAP plugin format
Projects
None yet
Development

No branches or pull requests

3 participants