Readme Instructions for building VST2 seems to have bad project paths

[doubletriplezero]

Ran into a little problem using the VST3 version of Surge XT in ableton 11. Not filing this as a bug here because i think it's a known ableton issue with VST3 plugins generally, but basically it was always logging some param config changes on startup so my projects would get marked dirty immediately upon startup even though nothing had really changed. Anyway, VST2 plugins don't seem to have this same issue and I was very happy to find out that you offered instructions for building out my own VST2 dlls for personal use. This is great and the instructions for doing so are very helpful, but there seems to be a bad path in a couple of the commands which may prove frustrating for anyone trying to build these.

when i got to this part with the commands for building the VST2 dlls:

cmake -Bbuild_vst2
cmake --build build_vst2 --config Release --target surge-xt_VST --parallel 4
cmake --build build_vst2 --config Release --target surge-fx_VST --parallel 4

the target project files were not found so i had to change the path to the VST2 projects like so:

cmake -Bbuild_vst2
cmake --build build_vst2 --config Release --target src/surge-xt/surge-xt_VST --parallel 4
cmake --build build_vst2 --config Release --target src/surge-fx/surge-fx_VST --parallel 4

after running successfully, the VST2 dlls were available at the following locations:

build_vst2\src\surge-xt\surge-xt_artefacts\Release\VST
build_vst2\src\surge-fx\surge-fx_artefacts\Release\VST

Thanks again for providing the ability to build out the VST2 version. Solved the issue in ableton and everything is working great now.

[mkruselj]

Feel free to open a pull request that fix the lines in question! Thanks for the report :)

[doubletriplezero]

Well I went back and double checked before submitting a PR and sorry to say this looks like user error on my part.

The first time I ran

cmake --build build_vst2 --config Release --target surge-xt_VST --parallel 4

it did fail to find the VST2 target, but not because of the path being incorrect. Rather it seems that the VST2 wrapper never got created in the first place. I may have not set the path to VST2SDK_DIR correctly. Since I couldn't get anything working, I started all over again and this time I think I set the path to VST2 SDK correctly. Since I still wasn't seeing the surge-xt_VST.vcxproj at the root of the build_vst2 directory, I assumed it would once again fail to be found, so I instead ran the build against the full path of the target. This did work, but it was not necessary. Tried again this morning with the original command from the ReadMe and all worked. Sorry for the confusion and thanks again for all the hard work on a great synth.

[mkruselj]

No problem! Glad you got it working in the end :)