Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does this really need monaco-editor as a peerDependency? #50

Closed
deadbeef84 opened this issue Nov 13, 2024 · 1 comment
Closed

Does this really need monaco-editor as a peerDependency? #50

deadbeef84 opened this issue Nov 13, 2024 · 1 comment

Comments

@deadbeef84
Copy link

I noticed that even though I'm using @monaco-editor/loader which I expected to load monaco from a CDN, I noticed monaco-editor in node_modules. It looks like it's being pulled in because @monaco-editor/loader specifies it as a peerDependency. Is this really necessary?
@suren-atoyan
Copy link
Owner

hi @deadbeef84 👋

It's removed from the peerDependencies in the latest version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deadbeef84 @suren-atoyan