[chore/bugfix] Implement federator.FederatingCallbacks
and federatingDB.Exists
properly
#1891
Milestone
federator.FederatingCallbacks
and federatingDB.Exists
properly
#1891
Right now, due to an unfortunate fuck-up by YOURS TRULY years ago, our go-fed FederatingCallbacks and Exists functions aren't implemented properly:
false
without doing any checks.The upshot of these misimplementations is that many activities are not handled properly in the initial call to resolve the federating callbacks, and so they're only handled properly by accident when the InboxForwarding function calls Create on an activity (when Exists returns false). This causes annoyances like #1744 and other things.
Steps to resolve this:
Implement Exists properly to check for (at least) statuses and accounts.[performance] reduce InboxForward->Create calls by partially implementing Exists() #3647Take that switch statement out of federatingDB.Create so that it's not doing all the heavy lifting, and move the other functionality into separate federatingDB functions.[chore] remove type switch in Create() and instead move to FederatedCallbacks() #3697Override other federating callbacks to call those new functions created in step 2.These fixes will also pave the way to potentially implementing inbox forwarding (#1890).
The text was updated successfully, but these errors were encountered: