Skip to content

Commit ff8def8

Browse files
committed
feat(eslint-plugin): Update deprecated @typescript-eslint/no-parameter-properties
1 parent a6a44f0 commit ff8def8

File tree

5 files changed

+16
-16
lines changed

5 files changed

+16
-16
lines changed

.eslintrc.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ module.exports = {
1212
extends: 'plugin:@superdispatch/ts-node',
1313
parserOptions: { project: './tsconfig.json' },
1414
rules: {
15-
'@typescript-eslint/no-parameter-properties': 'off',
15+
'@typescript-eslint/parameter-properties': 'off',
1616
},
1717
},
1818

@@ -34,7 +34,7 @@ module.exports = {
3434
files: '**/packages/eslint-plugin/src/configs/*.ts',
3535
rules: {
3636
'sort-keys': ['error', 'asc', { natural: true }],
37-
'@typescript-eslint/no-parameter-properties': 'off',
37+
'@typescript-eslint/parameter-properties': 'off',
3838
},
3939
},
4040

@@ -53,7 +53,7 @@ module.exports = {
5353
'plugin:eslint-plugin/tests-recommended',
5454
],
5555
rules: {
56-
'@typescript-eslint/no-parameter-properties': 'off',
56+
'@typescript-eslint/parameter-properties': 'off',
5757
},
5858
},
5959
],

packages/eslint-plugin/src/configs/ts-jest.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,6 @@ test('diff with jest', async () => {
221221
+ "@typescript-eslint/no-non-null-assertion": Array [
222222
+ "off",
223223
+ ],
224-
+ "@typescript-eslint/no-parameter-properties": Array [
225-
+ "error",
226-
+ ],
227224
+ "@typescript-eslint/no-redundant-type-constituents": Array [
228225
+ "error",
229226
+ ],
@@ -295,6 +292,9 @@ test('diff with jest', async () => {
295292
"@typescript-eslint/object-curly-spacing": Array [
296293
"off",
297294
],
295+
+ "@typescript-eslint/parameter-properties": Array [
296+
+ "error",
297+
+ ],
298298
+ "@typescript-eslint/prefer-as-const": Array [
299299
+ "error",
300300
+ ],

packages/eslint-plugin/src/configs/ts-node.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,6 @@ it('extends dependencies', async () => {
222222
+ "@typescript-eslint/no-non-null-assertion": Array [
223223
+ "error",
224224
+ ],
225-
+ "@typescript-eslint/no-parameter-properties": Array [
226-
+ "error",
227-
+ ],
228225
+ "@typescript-eslint/no-redundant-type-constituents": Array [
229226
+ "error",
230227
+ ],
@@ -296,6 +293,9 @@ it('extends dependencies', async () => {
296293
"@typescript-eslint/object-curly-spacing": Array [
297294
"off",
298295
+ ],
296+
+ "@typescript-eslint/parameter-properties": Array [
297+
+ "error",
298+
+ ],
299299
+ "@typescript-eslint/prefer-as-const": Array [
300300
+ "error",
301301
],

packages/eslint-plugin/src/configs/typescript.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -220,9 +220,6 @@ it('extends dependencies', async () => {
220220
+ "@typescript-eslint/no-non-null-assertion": Array [
221221
+ "error",
222222
+ ],
223-
+ "@typescript-eslint/no-parameter-properties": Array [
224-
+ "error",
225-
+ ],
226223
+ "@typescript-eslint/no-redundant-type-constituents": Array [
227224
+ "error",
228225
+ ],
@@ -279,24 +276,27 @@ it('extends dependencies', async () => {
279276
+ ],
280277
+ "@typescript-eslint/no-unused-vars": Array [
281278
"off",
282-
+ ],
279+
],
283280
+ "@typescript-eslint/no-use-before-define": Array [
284281
+ "error",
285282
+ Object {
286283
+ "classes": true,
287284
+ "functions": false,
288285
+ "typedefs": false,
289286
+ },
290-
],
287+
+ ],
291288
+ "@typescript-eslint/no-var-requires": Array [
292289
+ "error",
293290
+ ],
294291
"@typescript-eslint/object-curly-spacing": Array [
295292
"off",
293+
],
294+
+ "@typescript-eslint/parameter-properties": Array [
295+
+ "error",
296296
+ ],
297297
+ "@typescript-eslint/prefer-as-const": Array [
298298
+ "error",
299-
],
299+
+ ],
300300
+ "@typescript-eslint/prefer-for-of": Array [
301301
+ "error",
302302
+ ],

packages/eslint-plugin/src/configs/typescript.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ export function injectTypeScriptConfig(config: Linter.Config): void {
6969
'@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],
7070
'@typescript-eslint/no-implied-eval': 'error',
7171
'@typescript-eslint/no-non-null-assertion': 'error',
72-
'@typescript-eslint/no-parameter-properties': 'error',
7372
'@typescript-eslint/no-shadow': 'error',
7473
'@typescript-eslint/no-throw-literal': 'error',
7574
'@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
@@ -86,6 +85,7 @@ export function injectTypeScriptConfig(config: Linter.Config): void {
8685
'error',
8786
{ classes: true, functions: false, typedefs: false },
8887
],
88+
'@typescript-eslint/parameter-properties': 'error',
8989
'@typescript-eslint/prefer-for-of': 'error',
9090
'@typescript-eslint/prefer-function-type': 'error',
9191
'@typescript-eslint/prefer-includes': 'error',

0 commit comments

Comments
 (0)