Reexport pglsn or wrap it behind a struct

[GEverding]

Hi, trying to write a custom sink but your relying on a specific version of tokio-postgres for pglsn. Can you either wrap it or rexport it so I don't have to bring in another postgresql crate?

[imor]

PgLsn is unlikely to be the only type used from tokio-postgres so wrapping it won't be sufficient. What exactly is the problem you are running into with adding a dependency on tokio-postgres?

[GEverding]

Im trying to define this sink but the pg_lsn doesn't line up. I was going to try lining up versions next.

use pg_replicate::{
    conversions::{cdc_event::CdcEvent, table_row::TableRow},
    pipeline::{
        sinks::{BatchSink, SinkError},
        PipelineResumptionState,
    },
    table::{TableId, TableSchema},
};
use tokio;
use tokio_postgres::types::PgLsn;
use tracing::{debug, info, warn};

use crate::AppConfig;
use std::{
    collections::HashMap,
    sync::{Arc, Mutex},
};

#[derive(thiserror::Error, Debug)]
pub enum OpenmeterSinkError {}
impl SinkError for OpenmeterSinkError {}

#[derive(Clone)]
struct SinkProgress {
    last_lsn: Arc<Mutex<PgLsn>>,
}

#[derive(Clone)]
pub struct OpenmeterSink {
    progress: SinkProgress,
}

#[async_trait::async_trait]
impl BatchSink for OpenmeterSink {
    type Error = OpenmeterSinkError;

    async fn get_resumption_state(&mut self) -> Result<PipelineResumptionState, Self::Error> {
        todo!()
    }
    async fn write_table_schemas(
        &mut self,
        table_schemas: HashMap<TableId, TableSchema>,
    ) -> Result<(), Self::Error> {
        todo!()
    }
    async fn write_table_rows(
        &mut self,
        rows: Vec<TableRow>,
        table_id: TableId,
    ) -> Result<(), Self::Error> {
        todo!()
    }
    async fn write_cdc_events(
        &mut self,
        events: Vec<CdcEvent>,
    ) -> Result<tokio_postgres::types::PgLsn, Self::Error> {
        todo!()
    }
    async fn table_copied(&mut self, table_id: TableId) -> Result<(), Self::Error> {
        todo!()
    }
    async fn truncate_table(&mut self, table_id: TableId) -> Result<(), Self::Error> {
        todo!()
    }
}

error[E0053]: method `write_cdc_events` has an incompatible type for trait
  --> src/billing/openmeter_sink.rs:33:1
   |
33 | #[async_trait::async_trait]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `PgLsn`, found a different `PgLsn`
   |
   = note: expected signature `fn(&'life0 mut OpenmeterSink, std::vec::Vec<_>) -> Pin<Box<(dyn futures_util::Future<Output = Result<postgres_types::pg_lsn::PgLsn, OpenmeterSinkError>> + std::marker::Send + 'async_trait)>>`
              found signature `fn(&'life0 mut OpenmeterSink, std::vec::Vec<_>) -> Pin<Box<(dyn futures_util::Future<Output = Result<PgLsn, OpenmeterSinkError>> + std::marker::Send + 'async_trait)>>`
   = note: this error originates in the attribute macro `async_trait::async_trait` (in Nightly builds, run with -Z macro-backtrace for more info)
help: change the output type to match the trait
   |
33 | Pin<Box<(dyn futures_util::Future<Output = Result<postgres_types::pg_lsn::PgLsn, OpenmeterSinkError>> + std::marker::Send + 'async_trait)>>
   |

[GEverding]

So lining up the deps exactly works but not a nice solution imo.