Form validation errors result in 400 Response

[datenwerk-at]

Q	A
Bug?	yes
New Feature?	no
Sulu Version	Bundle 2.0.0; Sulu 2.5.10

Actual Behavior

When Comment-form validation fails a 400-http-Response is sent back.

Expected Behavior

Comments form with validation errors is shown.

Steps to Reproduce

Extend Comment entity and CommentForm type and add a property with some constraint (eg. NotBlank).
On submission of empty form the validation fails and a "Bad Request" Response (400) is sent back to the client.

Possible Solutions

Change form-action to referrer and let the form handle the request there?

[Prokyonn]

Hey @datenwerk-at, thank you for reporting the issue.

I investigated it, but I need you to confirm, if I understood it correctly :)

As far as I understand it, the issue is, that you get a 400 request instead of the rendered form with the error, is that correct?

I assume you want the error to be rendered in the form to give the user some kind of feedback. Furthermore the data should also not be lost right?

[alexander-schranz]

Think we need here:

SuluCommentBundle/Controller/WebsiteCommentController.php

Line 266 in 57b3db1

return new Response(null, 400);

Render the form containing the errors, in case the request is from requestFormat html. The response status code we should change to 422, if somebody uses hotwired turbo that status code would be required.

The more technical task here is that we need define a error format for JSON requests as in some projects the API is also used via JSON instead of symfony forms. There we maybe can orientated at the following issue: sulu/sulu#5809 (comment)

[datenwerk-at]

Hi guys, thanks for your comments.

As far as I understand it, the issue is, that you get a 400 request instead of the rendered form with the error, is that correct?

I assume you want the error to be rendered in the form to give the user some kind of feedback. Furthermore the data should also not be lost right?

That's exactly right.
And I think that Alex' outlined solution absolutely points in the right way.