Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus lost during Journal search #869

Open
quozl opened this issue Aug 29, 2019 · 3 comments
Open

Focus lost during Journal search #869

quozl opened this issue Aug 29, 2019 · 3 comments

Comments

@quozl
Copy link
Contributor

quozl commented Aug 29, 2019

Reproducer: create several journal objects, display the journal, click in the search box, begin typing the word "activity" slowly while watching the cursor. Repeat again but pause typing within the word.

Expected result: the word "activity" is in the box and the journal displays only those objects containing the word.

Observed result: if the pause is long enough, focus is lost, and the remaining letters typed are discarded.

@ShivanshRakesh
Copy link

Hi @quozl! I would like to work on this issue.

Won't changing value of _AUTOSEARCH_TIMEOUT in journaltoolbox.py from 1000 to something around 5000 fix this? Since, it looks like 1 sec is kind of too less for the same.

@quozl
Copy link
Contributor Author

quozl commented Oct 13, 2019

Thanks for letting us know. See Contributing which says "no need to ask permission to work on an issue."

Increasing _AUTOSEARCH_TIMEOUT like that will obviously break the automatic search function, and therefore not acceptable. The problem would still occur. However, consider temporarily decreasing it to 100 milliseconds to make testing and solving the problem easier.

I'm not here to explain how to fix the problem, I'd rather do it myself than explain it, but happy to answer any questions you may have about the problem, and to review the working solution you come up with.

@ShivanshRakesh
Copy link

Okay. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants