Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to explicitly disable resource requests or limits of Sophora Server #129

Open
hehu80 opened this issue Nov 4, 2024 · 1 comment
Open

Comments

@hehu80
Copy link
Contributor

hehu80 commented Nov 4, 2024

If you want to run the Sophora Server in a Cluster without setting resource requests or limits, you have to "delete" the default values by setting for example .Values.resources.limits to null in the values.yaml.
Unfortunately, deleting of default-values using null is still not possible while using Helm with sub-charts (see helm/helm#12879).
Adding an enabled flag to disable resources settings would be great.

For example:

resources:
  limits:
    enabled: true
    memory: "20Gi"
    cpu: "1.0"
  ...

to configure the resource limits

resources:
  limits:
    enabled: false
  ...

to run the Sophora Server without resource limits.

@hehu80
Copy link
Contributor Author

hehu80 commented Nov 4, 2024

#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant