Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve subo-generated SCN manifest #331

Open
flaki opened this issue Jul 20, 2022 · 0 comments
Open

Improve subo-generated SCN manifest #331

flaki opened this issue Jul 20, 2022 · 0 comments
Labels
devex Developer experience-related issues enhancement New feature or request

Comments

@flaki
Copy link
Contributor

flaki commented Jul 20, 2022

As mentioned in suborbital/docs#154 we should consider updating the subo-generated templates adding the non-autocert option for the builder. We should consider which usecase to make default, but can also inline the commented-out other configuration in the manifest for ease of switching.

Relevant snippets of the current scc-controlplane-deployment.yaml template:

          ports:
            - containerPort: 8080
            - containerPort: 8443


          env:
            - name: SCC_DOMAIN
              value: "{{ .BuilderDomain }}"


            - name: SCC_TLS_PORT
              value: "8443"
    - protocol: TCP
      name: challenge
      port: 80
      targetPort: 8080
    - protocol: TCP
      name: https
      port: 443
      targetPort: 8443
@flaki flaki added enhancement New feature or request devex Developer experience-related issues labels Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex Developer experience-related issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant