CI: Add job to run clang-tidy.

Author: fancycode

.clang-tidy

@@ -0,0 +1,13 @@
+---
+Checks: >
+  -clang-analyzer-security.insecureAPI.strcat,
+  -clang-analyzer-security.insecureAPI.strcpy,
+  modernize-shrink-to-fit,
+  modernize-use-default-member-init,
+  modernize-use-equals-default,
+  modernize-use-equals-delete,
+  modernize-use-override,
+  performance-*
+HeaderFilterRegex: .*
+WarningsAsErrors: '*'
+...

.github/workflows/clang.yml

@@ -37,3 +37,34 @@ jobs:
         CXX: clang++
       run: |
         ./scripts/run-ci.sh
+
+  tidy:
+    env:
+      WITH_GRAPHICS: 1
+      WITH_X265: 1
+      WITH_AOM: 1
+      WITH_DAV1D: 1
+      WITH_RAV1E: 1
+      WITH_LIBDE265: 1
+      CMAKE: 1
+      CLANG_TIDY: 1
+    runs-on: ubuntu-20.04
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: Install dependencies
+      run: |
+        ./scripts/install-ci-linux.sh
+        sudo apt install clang-tidy-12
+
+    - name: Prepare CI
+      run: |
+        ./scripts/prepare-ci.sh
+
+    - name: Run tests
+      run: |
+        ./scripts/run-ci.sh
+
+    - name: Run clang-tidy
+      run: |
+        run-clang-tidy-12 -j$(nproc)

scripts/run-ci.sh

@@ -133,6 +133,9 @@ if [ ! -z "$CMAKE" ]; then
     if [ "$WITH_RAV1E" = "1" ]; then
         CMAKE_OPTIONS="$CMAKE_OPTIONS -DUSE_LOCAL_RAV1E=1"
     fi
+    if [ "$CLANG_TIDY" = "1" ]; then
+        CMAKE_OPTIONS="$CMAKE_OPTIONS -DCMAKE_EXPORT_COMPILE_COMMANDS=ON"
+    fi
 
     cmake . $CMAKE_OPTIONS
 fi
@@ -141,7 +144,7 @@ if [ ! -z "$FUZZER" ] && [ "$CURRENT_OS" = "linux" ]; then
     export ASAN_SYMBOLIZER="$BUILD_ROOT/clang/bin/llvm-symbolizer"
 fi
 
-if [ -z "$EMSCRIPTEN_VERSION" ] && [ -z "$CHECK_LICENSES" ] && [ -z "$TARBALL" ]; then
+if [ -z "$EMSCRIPTEN_VERSION" ] && [ -z "$CHECK_LICENSES" ] && [ -z "$TARBALL" ] && [ -z "$CLANG_TIDY" ]; then
     echo "Building libheif ..."
     make -j $(nproc)
     if [ "$CURRENT_OS" = "linux" ] && [ -z "$CMAKE" ] && [ -z "$MINGW" ] && [ -z "$FUZZER" ]; then