Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong title "Front of identity card" #3597

Open
googol7 opened this issue May 22, 2024 · 4 comments
Open

[BUG] Wrong title "Front of identity card" #3597

googol7 opened this issue May 22, 2024 · 4 comments

Comments

@googol7
Copy link

googol7 commented May 22, 2024

Summary

We only accept driving licences but in the interface users get confused because the headers are "Front of identity card" and "Back of identity card".

In German this translates to "Vorderseite des Personalausweises" which is not a driving license.

See also:

Version

The problem occurs with stripe-ios 23.27.2

Details

We currently only accept driver's licences by defining options.document.allowed_types = ["driving_license"] when using the API

Available options are:

  • driving_license ... Drivers license document type.
  • id_card ... ID card document type.
  • passport ... Passport document type.

But in the interface the title is always "Front of identity card".

The text is "Position your identity card in the centre of the frame".

In the code you only use "Front of identity card" here.

iOS Native - English 2


On the first screen you use:
"Get ready to scan your photo ID"

iOS Native - English 1

@ccen-stripe
Copy link
Contributor

hi @googol7 We are working on a fix to make this word more generic, will update here

@googol7
Copy link
Author

googol7 commented Jul 4, 2024

@ccen-stripe Would it be helpful if we made a PR?

@googol7
Copy link
Author

googol7 commented Jul 5, 2024

@ccen-stripe I've seen that you have worked on it in the PR update translation for identity document.

@googol7
Copy link
Author

googol7 commented Jul 22, 2024

@ccen-stripe In the web version it explicitly says "driver’s licencse" if that is the only document that’s accepted. It would be perfect if the SDK would also do it like this:

  1. Get ready to scan your driver's license
    Grab your driver's license
  2. Front of driver's license
  3. Flip your ID over
    Get ready to scan the back of your ID
  4. Back of driver's license

0
1
2
3
4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants