Skip to content

bool(trace) should handle default values #278

Open
@sdementen

Description

@sdementen
    def __bool__(self):
        return bool(self._d)

should probably be rewritten as

    def __bool__(self):
        return bool(self._d) or bool(trace.default)

to see if is_empty should follow a similar logic with

    def is_empty(self):
        return len(self) == 0

rewritten as

    def is_empty(self):
        return len(self) == 0 and self.default is None

but I see it is used in bin() and check_boundaries() so not sure

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions