Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Initialize MemoryRecords builder with state from original request #14

Open
chris-giblin opened this issue Apr 24, 2022 · 0 comments
Open
Assignees

Comments

@chris-giblin
Copy link
Contributor

Currently during rewriting of partition data in encmod/src/main/java/io/strimzi/kafka/topicenc/EncryptionModule.java, a MemoryRecords builder is created mostly with default arguments. The builder however must be created with values matching the original request/response. This is a known limitation of the initial.

We do pass the baseOffset from the request but use default values for other fields such as compression type and timestamp type.

The derivation of the baseOffset must also be reviewed.

@chris-giblin chris-giblin self-assigned this Apr 24, 2022
@chris-giblin chris-giblin mentioned this issue Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant