[Physics] Fix reattach logic where component hasn't been attached yet (…

…#2465) Co-authored-by: Basewq <[email protected]>
stride3d · Sep 24, 2024 · 90522b7 · 90522b7
1 parent 2829889
commit 90522b7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/sources/engine/Stride.Physics/Elements/RigidbodyComponent.cs b/sources/engine/Stride.Physics/Elements/RigidbodyComponent.cs
@@ -119,7 +119,7 @@ public override ColliderShape ColliderShape
 
                 if (InternalRigidBody == null)
                 {
-                    if (!attachInProgress)
+                    if (Data != null && !attachInProgress)
                     {
                         //When setting ColliderShape, setup could have been previously skipped (eg when PhysicsComponent is created using GetOrCreate)
                         ReAttach();

diff --git a/sources/engine/Stride.Physics/Engine/PhysicsComponent.cs b/sources/engine/Stride.Physics/Engine/PhysicsComponent.cs
@@ -698,6 +698,10 @@ internal void Attach(PhysicsProcessor.AssociatedData data)
         /// </summary>
         internal void ReAttach()
         {
+            if (Data == null)
+            {
+                throw new InvalidOperationException("PhysicsComponent has not been attached yet.");
+            }
             //TODO: Could consider fully detaching and then rebuilding, but ideally this would cause null refs on Rigidbody OnDetach calls
             //Shouldnt call detach, because at this point the user has added new components and this runs as a check to rebuild as needed.
             //Entire wipes to rebuild causes loss in the data that the user has just added (and is slower)