Handle errors when flushing buffer in execout_walker

billettc · billettc · commit 6dd08829edb8 · 2026-02-25T10:57:43.000-05:00
diff --git a/orchestrator/execout/execout_walker.go b/orchestrator/execout/execout_walker.go
@@ -306,7 +306,9 @@ func (r *Walker) sendItems(reader execout.FileReader) error {
 
 	s := time.Now()
 	if r.supportBuffering {
-		return r.buffer.Flush(r.streamOut)
+		if err := r.buffer.Flush(r.streamOut); err != nil {
+			return fmt.Errorf("flushing buffer on end of iteration: %w", err)
+		}
 	}
 	flushingDuration += time.Since(s)
 

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,9 @@ func (r *Walker) sendItems(reader execout.FileReader) error {`
`306`	`306`
`307`	`307`	`s := time.Now()`
`308`	`308`	`if r.supportBuffering {`
`309`		`- return r.buffer.Flush(r.streamOut)`
	`309`	`+ if err := r.buffer.Flush(r.streamOut); err != nil {`
	`310`	`+ return fmt.Errorf("flushing buffer on end of iteration: %w", err)`
	`311`	`+ }`
`310`	`312`	`}`
`311`	`313`	`flushingDuration += time.Since(s)`
`312`	`314`