add legacy solo mining compatibility

Author: lucasbalieiro

pool-apps/pool/README.md

@@ -101,6 +101,7 @@ Miners must specify their payout mode via `user_identity`:
 |---------|------|-------------|
 | `sri/donate/worker_name` | Pool | Full reward goes to pool |
 | `sri/solo/payout_address/worker_name` | Solo | Full reward goes to miner's address |
+| `bc1qtzqxqaxyy6lda2fhdtp5dp0v56vlf6g0tljy2x` | Solo | Full reward goes to miner's address |
 | `sri/donate/percentage/payout_address/worker_name` | Donate | Pool gets %, miner gets remainder *(not yet implemented)* |
 
 ### Error Scenarios

pool-apps/pool/src/lib/channel_manager/mining_message_handler.rs

@@ -147,7 +147,7 @@ impl HandleMiningMessagesFromClientAsync for ChannelManager {
             let payout_mode = match validate_user_identity(&user_identity, self.solo_mining_mode) {
                 Ok(mode) => mode,
                 Err(_) => {
-                    error!("Invalid user_identity '{}': must be 'sri/donate/<worker_name>' or 'sri/solo/<payout_address>/<worker_name>'", user_identity);
+                    error!("Invalid user_identity '{}': must be 'sri/donate/<worker_name>', 'sri/solo/<payout_address>/<worker_name>' or `<bitcoin_address>`", user_identity);
                     let open_standard_mining_channel_error = OpenMiningChannelError {
                         request_id,
                         error_code: "invalid-user-identity"
@@ -358,7 +358,7 @@ impl HandleMiningMessagesFromClientAsync for ChannelManager {
                         let payout_mode = match validate_user_identity(&user_identity, self.solo_mining_mode) {
                             Ok(mode) => mode,
                             Err(_) => {
-                                error!("Invalid user_identity '{}': must be 'sri/donate/<worker_name>' or 'sri/solo/<payout_address>/<worker_name>'", user_identity);
+                                error!("Invalid user_identity '{}': must be 'sri/donate/<worker_name>', 'sri/solo/<payout_address>/<worker_name>' or <bitcoin_address>", user_identity);
                                 let open_extended_mining_channel_error = OpenMiningChannelError {
                                     request_id,
                                     error_code: "invalid-user-identity"

pool-apps/pool/src/lib/utils.rs

@@ -1,5 +1,6 @@
 use std::net::SocketAddr;
 use stratum_apps::{
+    config_helpers::CoinbaseRewardScript,
     stratum_core::{
         binary_sv2::Str0255,
         common_messages_sv2::{Protocol, SetupConnection},
@@ -116,6 +117,11 @@ pub fn validate_user_identity(
         return Ok(PayoutMode::Pool);
     }
 
+    let descriptor = format!("addr({user_identity})");
+    if CoinbaseRewardScript::from_descriptor(&descriptor).is_ok() {
+        return Ok(PayoutMode::Solo(user_identity.to_string()));
+    }
+
     let parts: Vec<&str> = user_identity.split('/').collect();
 
     if parts.is_empty() || parts[0] != "sri" || parts.len() < 2 {
@@ -207,6 +213,10 @@ mod tests {
             validate_user_identity("sri/solo/tb1qxyz/worker/subworker", true),
             Ok(PayoutMode::Solo(addr)) if addr == "tb1qxyz"
         ));
+        assert!(matches!(
+            validate_user_identity("bc1qtzqxqaxyy6lda2fhdtp5dp0v56vlf6g0tljy2x", true),
+            Ok(PayoutMode::Solo(addr)) if addr == "bc1qtzqxqaxyy6lda2fhdtp5dp0v56vlf6g0tljy2x"
+        ));
     }
 
     #[test]