Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random lua error after the last update #123

Open
Pocokk opened this issue Nov 3, 2023 · 1 comment
Open

Random lua error after the last update #123

Pocokk opened this issue Nov 3, 2023 · 1 comment

Comments

@Pocokk
Copy link

Pocokk commented Nov 3, 2023

2x Guildbook/GuildbookMixin.lua:473: attempt to compare nil with string
[string "@Guildbook/GuildbookMixin.lua"]:473: in function <Guildbook/GuildbookMixin.lua:461>
[string "=[C]"]: in function sort' [string "@Guildbook/GuildbookMixin.lua"]:461: in function UpdateMinimapTooltip'
[string "@Guildbook/GuildbookMixin.lua"]:514: in function `UpdateTooltip'
[string "@Guildbook/GuildbookMixin.lua"]:519: in function <Guildbook/GuildbookMixin.lua:517>

Locals:
a =

{
classID = 2
level = 80
name = "Iringobeax-MirageRaceway"
}
b =
{
classID = 2
level = 80
name = "Omän-MirageRaceway"
zone = "Darnassus"
}
(*temporary) = nil
(*temporary) = "Darnassus"
(*temporary) = "attempt to compare nil with string"

@stpain
Copy link
Owner

stpain commented Nov 3, 2023

Hi thanks, I think the issue is where the client hasn't got a players location, maybe due to an instance or RDF group.

I have added some checks around this now to prevent nil values going into the sort function.

if (name ~= nil) and (obj.data.class ~= nil) and (obj.data.level ~= nil) and obj.data.onlineStatus.isOnline then table.insert(t, { name = name, classID = obj.data.class, level = obj.data.level, zone = obj.data.onlineStatus.zone or "-", }) end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants