Skip to content

Commit b9c6438

Browse files
committed
add support for multiple configurations, uglify by default and fix watchers
1 parent c412129 commit b9c6438

File tree

5 files changed

+19
-16
lines changed

5 files changed

+19
-16
lines changed

index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ module.exports = function(gulp, tasks, config) {
1616
}
1717

1818
if (tasks.indexOf('configScripts') !== -1) {
19-
require('./tasks/configScripts')(gulp, config.app.config, config.configName, config.dist.js);
19+
require('./tasks/configScripts')(gulp, config.env.constants, config.configName, config.dist.js);
2020
}
2121

2222
if (tasks.indexOf('connect') !== -1) {
@@ -76,7 +76,7 @@ module.exports = function(gulp, tasks, config) {
7676
}
7777

7878
if (tasks.indexOf('sass') !== -1) {
79-
require('./tasks/sass')(gulp, config.app.scss, config.dist.css, config.production, config.sourceMapsPath);
79+
require('./tasks/sass')(gulp, config.app.scss, config.dist.css, config.sourceMapsPath);
8080
}
8181

8282
if (tasks.indexOf('scripts') !== -1) {
@@ -92,7 +92,7 @@ module.exports = function(gulp, tasks, config) {
9292
}
9393

9494
if (tasks.indexOf('vendorScripts') !== -1) {
95-
require('./tasks/vendorScripts')(gulp, config.dist.js, config.sourcemapPath, config.production, config.debug);
95+
require('./tasks/vendorScripts')(gulp, config.dist.js, config.sourcemapPath, config.debug);
9696
}
9797

9898
if (tasks.indexOf('vendorStyles') !== -1) {

tasks/configScripts.js

+10-6
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,18 @@
11
'use strict';
22

3-
var ngConstant = require('gulp-ng-constant');
3+
var ngConstant = require('gulp-ng-constant'),
4+
//gulpif = require('gulp-if'),
5+
//rev = require('gulp-rev'),
6+
uglify = require('gulp-uglify');
47

5-
6-
module.exports = function(gulp, config, name, dest) {
8+
module.exports = function(gulp, constants, name, dest) {
79
gulp.task('configScripts', function() {
8-
gulp.src(config)
9-
.pipe(ngConstant({
10+
ngConstant({
11+
constants: constants,
1012
name: name
11-
}))
13+
})
14+
.pipe(uglify())
15+
//.pipe(gulpif(config.env.rev, rev()))
1216
.pipe(gulp.dest(dest));
1317
});
1418
};

tasks/sass.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ var sass = require('gulp-sass'),
66
//revReplace = require('gulp-rev-replace'),
77

88

9-
module.exports = function(gulp, src, dest, uglifyFlag, sourceMapsPath) {
9+
module.exports = function(gulp, src, dest, sourceMapsPath) {
1010
gulp.task('styles', [], function (done) {
1111
var options = {
12-
outputStyle: uglifyFlag ? 'compressed' : 'nested'
12+
outputStyle: 'compressed'
1313
};
1414

1515
//var revOptions = {

tasks/vendorScripts.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ var jsFilter = {
1515
filter: /\.js$/i
1616
};
1717

18-
module.exports = function(gulp, dest, sourceMapPath, production, debugFlag) {
18+
module.exports = function(gulp, dest, sourceMapPath, debugFlag) {
1919
gulp.task('vendorScripts', ['bower:install', 'bower:prune'], function(done) {
2020
gulp.src(bowerFiles(jsFilter))
2121
.pipe(gulpif(debugFlag, debug()))
2222
.pipe(sourceMaps.init())
2323
.pipe(gulpif(isFirstRun, newer(dest + vendorFile)))
2424
.pipe(concat(vendorFile))
25-
.pipe(gulpif(production, uglify()))
25+
.pipe(uglify())
2626
.pipe(sourceMaps.write(sourceMapPath))
2727
.pipe(gulp.dest(dest));
2828

tasks/watch.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ module.exports = function(gulp, config) {
99
gulp.watch(config.app.views, ['partials']);
1010
gulp.watch(config.app.statics, ['statics']);
1111
gulp.watch(config.app.images, ['images']);
12-
gulp.watch(config.app.scssAll, ['compass']);
13-
gulp.watch(config.app.config, ['config']);
12+
gulp.watch(config.app.scssAll, ['styles']);
1413
gulp.watch(config.app.js, ['scripts']);
15-
gulp.watch(config.bowerjson, ['vendorScripts', 'vendorStyles', 'fonts']);
14+
gulp.watch(config.bowerjson, ['vendorScripts', 'vendorStyles', 'vendorFonts']);
1615
// watch any change in dist folder; reload immediately in case of detected change
1716
gulp.watch(config.bases.dist + '**', ['reload']);
1817
});

0 commit comments

Comments
 (0)