PHP Strict Standards

[Caberhagen]

Hi

combat is working.
have after a combat situation an output in log:

PHP Strict Standards: Only variables should be passed by reference in /var/stfc/scheduler/moves_common.php on line 786

[kirirur]

This should be filled in Scheduler repository, however this is more a warning then an error, searching on google I've found this article: http://stackoverflow.com/questions/2354609/strict-standards-only-variables-should-be-passed-by-reference, that explains also how to fix it.

Instead of have:
if($this->do_ship_combat(implode(',', $atk_fleet_ids), $this->fleet_ids_str, MV_COMBAT_LEVEL_OUTER) == MV_EXEC_ERROR)

the code should be changed like this:

$atk_fleet_ids_str = implode(',', $atk_fleet_ids);
if($this->do_ship_combat($atk_fleet_ids_str, $this->fleet_ids_str, MV_COMBAT_LEVEL_OUTER) == MV_EXEC_ERROR)

That's because do_ship_combat is declared with pass-by-reference arguments and starting from PHP 5.4 only variable can be passed by reference.

Let me know if modifying the code in this way it works.

[Caberhagen]

ok i try this fix. feedback follow.

[Caberhagen]

Found the next code to change:

moves_action41.php is the next php-strict-standrad output in log:

if($this->do_ship_combat(implode(',', $atk_fleets_ids), implode(',', $dfd_fleet_ids), MV_COMBAT_LEVEL_ORBITAL) == MV_EXEC_ERROR)

how i change them?

[kirirur]

Hi,

you have to search all do_ship_combat call and be sure to call it only with variables. In the code above you have to remove the call to implode function and assign them to a couple of variables before calling the do_ship_combat.

Besides I'm wondering if pass by reference is really needed here, since it seems a variable is never used...