Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/strict types #118

Closed
wants to merge 11 commits into from
Closed

Conversation

firehudson
Copy link

@firehudson firehudson commented Aug 22, 2023

PR includes the following changes:

  • Enable strict mode in typescript configuration
  • Fix common typescript issues and enforce types where-ever possible

@vercel
Copy link

vercel bot commented Aug 22, 2023

@firehudson is attempting to deploy a commit to the Elegance Team on Vercel.

A member of the Team first needs to authorize it.

@firehudson firehudson marked this pull request as ready for review August 24, 2023 12:43
@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
novel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 5:09am

@steven-tey
Copy link
Owner

@firehudson love this! Since we recently migrated to a monorepo structure, can you please refactor this PR to resolve the merge conflicts? Here are some instructions: https://github.com/steven-tey/novel#setting-up-locally

@andrewdoro
Copy link
Collaborator

I'll close this PR, I'll make a new PR adding strict, mosty because the structure has totally changed

@andrewdoro andrewdoro closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants