Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type "button" on components buttons to avoid send form #112

Merged
merged 9 commits into from
Aug 26, 2023
Merged

fix: add type "button" on components buttons to avoid send form #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c1310b1
fix: add type "button" on bubble-menu buttons to avoid send form
SmookeyDev Aug 12, 2023
34f87f3
fix: node-selector buttons
SmookeyDev Aug 12, 2023
9161241
fix: color-selector buttons
SmookeyDev Aug 12, 2023
ec42dde
fix: refactory link-selector, to avoid send form if editor inside on …
SmookeyDev Aug 12, 2023
2a9dc0e
fix: link-selector
SmookeyDev Aug 12, 2023
ba65045
chore: move EditorBubbleMenu to outside Editor div, to prevent wrong …
SmookeyDev Aug 12, 2023
899930f
Merge branch 'main' into pr/112
steven-tey Aug 26, 2023
998802f
Update index.tsx
steven-tey Aug 26, 2023
f7541f0
Update link-selector.tsx
steven-tey Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/editor/components/bubble-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ export const EditorBubbleMenu: FC<EditorBubbleMenuProps> = (props) => {
key={index}
onClick={item.command}
className="p-2 text-stone-600 hover:bg-stone-100 active:bg-stone-200"
type="button"
>
<item.icon
className={cn("h-4 w-4", {
Expand Down
2 changes: 2 additions & 0 deletions ui/editor/components/color-selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ export const ColorSelector: FC<ColorSelectorProps> = ({
setIsOpen(false);
}}
className="flex items-center justify-between rounded-sm px-2 py-1 text-sm text-stone-600 hover:bg-stone-100"
type="button"
>
<div className="flex items-center space-x-2">
<div
Expand Down Expand Up @@ -169,6 +170,7 @@ export const ColorSelector: FC<ColorSelectorProps> = ({
setIsOpen(false);
}}
className="flex items-center justify-between rounded-sm px-2 py-1 text-sm text-stone-600 hover:bg-stone-100"
type="button"
>
<div className="flex items-center space-x-2">
<div
Expand Down
2 changes: 2 additions & 0 deletions ui/editor/components/link-selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export const LinkSelector: FC<LinkSelectorProps> = ({
return (
<div className="relative">
<button
type="button"
className="flex h-full items-center space-x-2 px-3 py-1.5 text-sm font-medium text-stone-600 hover:bg-stone-100 active:bg-stone-200"
onClick={() => {
setIsOpen(!isOpen);
Expand Down Expand Up @@ -58,6 +59,7 @@ export const LinkSelector: FC<LinkSelectorProps> = ({
/>
{editor.getAttributes("link").href ? (
<button
type="button"
className="flex items-center rounded-sm p-1 text-red-600 transition-all hover:bg-red-100 dark:hover:bg-red-800"
onClick={() => {
editor.chain().focus().unsetLink().run();
Expand Down
1 change: 1 addition & 0 deletions ui/editor/components/node-selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ export const NodeSelector: FC<NodeSelectorProps> = ({
setIsOpen(false);
}}
className="flex items-center justify-between rounded-sm px-2 py-1 text-sm text-stone-600 hover:bg-stone-100"
type="button"
>
<div className="flex items-center space-x-2">
<div className="rounded-sm border border-stone-200 p-1">
Expand Down