test: migrate remaining public-api tests to Bazel (angular#22639)

We now create npm packages to cover all the public api assertions in tools/public_api_guard.
We no longer depend on ts-api-guardian from npm - it is now stale since the repository was archived.
There is no longer a gulp task to enforce or accept the public API, this is in CircleCI as part of running all bazel test targets.

PR Close angular#22639

Author: alexeagle

aio/tools/transforms/angular-api-package/index.js

@@ -43,7 +43,7 @@ module.exports = new Package('angular-api', [basePackage, typeScriptPackage])
     readTypeScriptModules.ignoreExportsMatching = [/^[_ɵ]|^VERSION$/];
     readTypeScriptModules.hidePrivateMembers = true;
 
-    // NOTE: This list shold be in sync with tools/gulp-tasks/public-api.js
+    // NOTE: This list shold be in sync with tools/public_api_guard/BUILD.bazel
     readTypeScriptModules.sourceFiles = [
       'animations/index.ts',
       'animations/browser/index.ts',

gulpfile.js

@@ -31,8 +31,6 @@ gulp.task('format:enforce', loadTask('format', 'enforce'));
 gulp.task('format', loadTask('format', 'format'));
 gulp.task('build.sh', loadTask('build', 'all'));
 gulp.task('build.sh:no-bundle', loadTask('build', 'no-bundle'));
-gulp.task('public-api:enforce', loadTask('public-api', 'enforce'));
-gulp.task('public-api:update', ['build.sh'], loadTask('public-api', 'update'));
 gulp.task('lint', ['format:enforce', 'validate-commit-messages', 'tslint']);
 gulp.task('tslint', ['tools:build'], loadTask('lint'));
 gulp.task('validate-commit-messages', loadTask('validate-commit-message'));

package.json

@@ -100,7 +100,6 @@
     "source-map": "0.5.7",
     "source-map-support": "0.4.18",
     "systemjs": "0.18.10",
-    "ts-api-guardian": "^0.3.0",
     "tsickle": "0.26.0",
     "tslint": "5.7.0",
     "tslint-eslint-rules": "4.1.1",

packages/animations/BUILD.bazel

@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ng_module")
+load("//tools:defaults.bzl", "ng_module", "ng_package")
 
 ng_module(
     name = "animations",
@@ -15,3 +15,18 @@ ng_module(
         "//packages/core",
     ],
 )
+
+ng_package(
+    name = "npm_package",
+    srcs = ["package.json"],
+    entry_point = "packages/animations/index.js",
+    secondary_entry_points = [
+        "browser",
+        "browser/testing",
+    ],
+    deps = [
+        ":animations",
+        "//packages/animations/browser",
+        "//packages/animations/browser/testing",
+    ],
+)

packages/animations/browser/src/private_export.ts

@@ -8,9 +8,11 @@
 export {Animation as ɵAnimation} from './dsl/animation';
 export {AnimationStyleNormalizer as ɵAnimationStyleNormalizer, NoopAnimationStyleNormalizer as ɵNoopAnimationStyleNormalizer} from './dsl/style_normalization/animation_style_normalizer';
 export {WebAnimationsStyleNormalizer as ɵWebAnimationsStyleNormalizer} from './dsl/style_normalization/web_animations_style_normalizer';
-export {NoopAnimationDriver as ɵNoopAnimationDriver} from './render/animation_driver';
+export {AnimationDriver as ɵAnimationDriver, NoopAnimationDriver as ɵNoopAnimationDriver} from './render/animation_driver';
 export {AnimationEngine as ɵAnimationEngine} from './render/animation_engine_next';
 export {CssKeyframesDriver as ɵCssKeyframesDriver} from './render/css_keyframes/css_keyframes_driver';
 export {CssKeyframesPlayer as ɵCssKeyframesPlayer} from './render/css_keyframes/css_keyframes_player';
+export {containsElement as ɵcontainsElement, invokeQuery as ɵinvokeQuery, matchesElement as ɵmatchesElement, validateStyleProperty as ɵvalidateStyleProperty} from './render/shared';
 export {WebAnimationsDriver as ɵWebAnimationsDriver, supportsWebAnimations as ɵsupportsWebAnimations} from './render/web_animations/web_animations_driver';
 export {WebAnimationsPlayer as ɵWebAnimationsPlayer} from './render/web_animations/web_animations_player';
+export {allowPreviousPlayerStylesMerge as ɵallowPreviousPlayerStylesMerge} from './util';

packages/animations/browser/testing/BUILD.bazel

@@ -4,7 +4,6 @@ load("//tools:defaults.bzl", "ng_module")
 
 ng_module(
     name = "testing",
-    testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/animations/browser/testing",
     deps = [

packages/animations/browser/testing/rollup.config.js

@@ -12,6 +12,7 @@ const sourcemaps = require('rollup-plugin-sourcemaps');
 const globals = {
   '@angular/core': 'ng.core',
   '@angular/animations': 'ng.animations',
+  '@angular/animations/browser': 'ng.animations.browser',
   'rxjs/Observable': 'Rx',
   'rxjs/Subject': 'Rx',
 };

packages/animations/browser/testing/src/mock_animation_driver.ts

@@ -6,10 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 import {AUTO_STYLE, AnimationPlayer, NoopAnimationPlayer, ɵStyleData} from '@angular/animations';
-
-import {AnimationDriver} from '../../src/render/animation_driver';
-import {containsElement, invokeQuery, matchesElement, validateStyleProperty} from '../../src/render/shared';
-import {allowPreviousPlayerStylesMerge} from '../../src/util';
+import {ɵAnimationDriver as AnimationDriver, ɵallowPreviousPlayerStylesMerge as allowPreviousPlayerStylesMerge, ɵcontainsElement as containsElement, ɵinvokeQuery as invokeQuery, ɵmatchesElement as matchesElement, ɵvalidateStyleProperty as validateStyleProperty} from '@angular/animations/browser';
 
 
 /**

packages/animations/browser/testing/tsconfig-build.json

@@ -6,6 +6,7 @@
     "rootDir": "../../",
     "paths": {
       "@angular/animations": ["../../../../dist/packages/animations"],
+      "@angular/animations/browser": ["../../../../dist/packages/animations/browser"],
       "@angular/core": ["../../../../dist/packages/core"]
     },
     "outDir": "../../../../dist/packages/animations"

packages/bazel/src/ng_package/ng_package.bzl

@@ -16,37 +16,54 @@ load("//packages/bazel/src:esm5.bzl", "esm5_outputs_aspect", "ESM5Info")
 # TODO(alexeagle): this list is incomplete, add more as material ramps up
 WELL_KNOWN_GLOBALS = {
     "@angular/core": "ng.core",
+    "@angular/core/testing": "ng.core.testing",
     "@angular/common": "ng.common",
+    "@angular/compiler": "ng.compiler",
+    "@angular/compiler/testing": "ng.compiler.testing",
     "@angular/platform-browser": "ng.platformBrowser",
+    "@angular/platform-browser/testing": "ng.platformBrowser.testing",
+    "@angular/platform-browser-dynamic": "ng.platformBrowserDynamic",
 }
 WELL_KNOWN_GLOBALS.update({"rxjs/%s" % s: "Rx" for s in [
     "BehaviorSubject",
+    "ConnectableObservable",
     "Observable",
     "Observer",
     "Subject",
     "Subscription",
+    "ReplaySubject",
     "util/EmptyError",
 ]})
 WELL_KNOWN_GLOBALS.update({"rxjs/observable/%s" % s: "Rx.Observable" for s in [
+    "concat",
+    "defer",
     "from",
+    "fromEvent",
     "fromPromise",
     "forkJoin",
     "merge",
+    "never",
     "of",
+    "throw",
 ]})
 WELL_KNOWN_GLOBALS.update({"rxjs/operator/%s" % s: "Rx.Observable.prototype" for s in [
     "catch",
     "concatAll",
     "concatMap",
+    "do",
     "every",
     "first",
     "filter",
     "last",
     "map",
     "mergeAll",
     "mergeMap",
+    "publish",
     "reduce",
     "share",
+    "startWith",
+    "switchMap",
+    "take",
     "toPromise",
 ]})
 
@@ -238,7 +255,7 @@ def ng_package_outputs(name, entry_point):
   # we assume the files should be named "package.*.js"
   basename = entry_point.split("/")[-2] if entry_point.find("/") >=0 else name
   return {
-      "fesm5": "%s.js" % basename,
+      "fesm5": "fesm5/%s.js" % basename,
       "fesm2015": "fesm2015/%s.js" % basename,
       "umd": "%s.umd.js" % basename,
       "umd_min": "%s.umd.min.js" % basename,

packages/common/BUILD.bazel

@@ -19,6 +19,7 @@ ng_module(
 
 ng_package(
     name = "npm_package",
+    srcs = ["package.json"],
     entry_point = "packages/common/index.js",
     secondary_entry_points = [
         "testing",

packages/compiler/BUILD.bazel

@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library", "ng_package")
 
 ts_library(
     name = "compiler",
@@ -12,3 +12,16 @@ ts_library(
     ),
     module_name = "@angular/compiler",
 )
+
+ng_package(
+    name = "npm_package",
+    srcs = ["package.json"],
+    entry_point = "packages/compiler/compiler.js",
+    secondary_entry_points = [
+        "testing",
+    ],
+    deps = [
+        ":compiler",
+        "//packages/compiler/testing",
+    ],
+)

packages/compiler/testing/BUILD.bazel

@@ -4,7 +4,6 @@ load("//tools:defaults.bzl", "ts_library")
 
 ts_library(
     name = "testing",
-    testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/compiler/testing",
     deps = [

packages/forms/BUILD.bazel

@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ng_module")
+load("//tools:defaults.bzl", "ng_module", "ng_package")
 
 ng_module(
     name = "forms",
@@ -17,3 +17,12 @@ ng_module(
         "@rxjs",
     ],
 )
+
+ng_package(
+    name = "npm_package",
+    srcs = ["package.json"],
+    entry_point = "packages/forms/index.js",
+    deps = [
+        ":forms",
+    ],
+)

packages/http/BUILD.bazel

@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ng_module")
+load("//tools:defaults.bzl", "ng_module", "ng_package")
 
 ng_module(
     name = "http",
@@ -17,3 +17,16 @@ ng_module(
         "@rxjs",
     ],
 )
+
+ng_package(
+    name = "npm_package",
+    srcs = ["package.json"],
+    entry_point = "packages/http/index.js",
+    secondary_entry_points = [
+        "testing",
+    ],
+    deps = [
+        ":http",
+        "//packages/http/testing",
+    ],
+)

packages/http/testing/BUILD.bazel

@@ -4,7 +4,6 @@ load("//tools:defaults.bzl", "ng_module")
 
 ng_module(
     name = "testing",
-    testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/http/testing",
     deps = [

packages/platform-browser-dynamic/BUILD.bazel

@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ng_module")
+load("//tools:defaults.bzl", "ng_module", "ng_package")
 
 ng_module(
     name = "platform-browser-dynamic",
@@ -19,3 +19,16 @@ ng_module(
         "//packages/platform-browser",
     ],
 )
+
+ng_package(
+    name = "npm_package",
+    srcs = ["package.json"],
+    entry_point = "packages/platform-browser-dynamic/index.js",
+    secondary_entry_points = [
+        "testing",
+    ],
+    deps = [
+        ":platform-browser-dynamic",
+        "//packages/platform-browser-dynamic/testing",
+    ],
+)

packages/platform-browser-dynamic/testing/BUILD.bazel

@@ -4,7 +4,6 @@ load("//tools:defaults.bzl", "ng_module")
 
 ng_module(
     name = "testing",
-    testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/platform-browser-dynamic/testing",
     deps = [

packages/platform-browser/BUILD.bazel

@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ng_module")
+load("//tools:defaults.bzl", "ng_module", "ng_package")
 
 ng_module(
     name = "platform-browser",
@@ -17,3 +17,18 @@ ng_module(
         "//packages/core",
     ],
 )
+
+ng_package(
+    name = "npm_package",
+    srcs = ["package.json"],
+    entry_point = "packages/platform-browser/index.js",
+    secondary_entry_points = [
+        "animations",
+        "testing",
+    ],
+    deps = [
+        ":platform-browser",
+        "//packages/platform-browser/animations",
+        "//packages/platform-browser/testing",
+    ],
+)

packages/platform-browser/testing/BUILD.bazel

@@ -4,7 +4,6 @@ load("//tools:defaults.bzl", "ng_module")
 
 ng_module(
     name = "testing",
-    testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/platform-browser/testing",
     deps = [

packages/platform-server/BUILD.bazel

@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ng_module")
+load("//tools:defaults.bzl", "ng_module", "ng_package")
 
 ng_module(
     name = "platform-server",
@@ -24,3 +24,16 @@ ng_module(
         "@rxjs",
     ],
 )
+
+ng_package(
+    name = "npm_package",
+    srcs = ["package.json"],
+    entry_point = "packages/platform-server/index.js",
+    secondary_entry_points = [
+        "testing",
+    ],
+    deps = [
+        ":platform-server",
+        "//packages/platform-server/testing",
+    ],
+)

packages/platform-server/testing/BUILD.bazel

@@ -4,7 +4,6 @@ load("//tools:defaults.bzl", "ng_module")
 
 ng_module(
     name = "testing",
-    testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/platform-server/testing",
     deps = [

packages/platform-webworker-dynamic/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module", "ng_package")
 
-ts_library(
+ng_module(
     name = "platform-webworker-dynamic",
     srcs = glob(
         [
@@ -19,3 +19,10 @@ ts_library(
         "//packages/platform-browser-dynamic",
     ],
 )
+
+ng_package(
+    name = "npm_package",
+    srcs = ["package.json"],
+    entry_point = "packages/platform-webworker-dynamic/index.js",
+    deps = [":platform-webworker-dynamic"],
+)