Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with react-waypoint@9 #152

Open
ckeeney opened this issue Sep 24, 2019 · 1 comment
Open

Incompatible with react-waypoint@9 #152

ckeeney opened this issue Sep 24, 2019 · 1 comment

Comments

@ckeeney
Copy link

ckeeney commented Sep 24, 2019 •
edited
Loading

react-ideal-image@^0.0.5:
version "0.0.5"
resolved "https://registry.yarnpkg.com/react-ideal-image/-/react-ideal-image-0.0.5.tgz#92a1d6e7e6d5a32b2a6a41e82ffb7f122ed9bddf"
integrity sha512-Xc/uyfigjE9nt5RPnEnvVVCxdrkVNRpvh1+WaCLTEk28jrshB1mM5/iA0Adxp2zqITT4aqx/C8CFNs02EskK0Q==

  • node version: 11.15.0

Problem description:
react-idea-image gets a Warning: React.createElement: type is invalid -- expected a string error with react-waypoint>9.
Suggested solution:

I haven't looked into what's required to make react-ideal-image compatible with react-waypoint@9, but just documenting that react-waypoint@8 would be a big improvement. Right now the only hint of that is by checking this repo's package.json file.
@endiliey
Copy link

Its because v9 used a named export instead of default export

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckeeney @endiliey