Fix SetOpSourceAccount silently ignoring invalid source account errors

tamirms · claude · tamirms · commit 739aec68f447 · 2026-02-24T21:30:00.000Z
SetOpSourceAccount was discarding the error returned by
MuxedAccount.SetAddress, which could produce a partially initialized
MuxedAccount that panics on subsequent Address() calls. Return the
error instead and check it in all 27 BuildXDR callers.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/txnbuild/account_merge.go b/txnbuild/account_merge.go
@@ -26,7 +26,9 @@ func (am *AccountMerge) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, am.SourceAccount)
+	if err = SetOpSourceAccount(&op, am.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/allow_trust.go b/txnbuild/allow_trust.go
@@ -56,7 +56,9 @@ func (at *AllowTrust) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, at.SourceAccount)
+	if err = SetOpSourceAccount(&op, at.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/begin_sponsoring_future_reserves.go b/txnbuild/begin_sponsoring_future_reserves.go
@@ -27,7 +27,9 @@ func (bs *BeginSponsoringFutureReserves) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, bs.SourceAccount)
+	if err = SetOpSourceAccount(&op, bs.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/bump_sequence.go b/txnbuild/bump_sequence.go
@@ -21,7 +21,9 @@ func (bs *BumpSequence) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, bs.SourceAccount)
+	if err = SetOpSourceAccount(&op, bs.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/change_trust.go b/txnbuild/change_trust.go
@@ -58,7 +58,9 @@ func (ct *ChangeTrust) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, ct.SourceAccount)
+	if err = SetOpSourceAccount(&op, ct.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/claim_claimable_balance.go b/txnbuild/claim_claimable_balance.go
@@ -31,7 +31,9 @@ func (cb *ClaimClaimableBalance) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, cb.SourceAccount)
+	if err = SetOpSourceAccount(&op, cb.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 
 	return op, nil
 }
diff --git a/txnbuild/clawback.go b/txnbuild/clawback.go
@@ -54,7 +54,9 @@ func (cb *Clawback) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR Operation")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, cb.SourceAccount)
+	if err = SetOpSourceAccount(&op, cb.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/clawback_claimable_balance.go b/txnbuild/clawback_claimable_balance.go
@@ -30,7 +30,9 @@ func (cb *ClawbackClaimableBalance) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, cb.SourceAccount)
+	if err = SetOpSourceAccount(&op, cb.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 
 	return op, nil
 }
diff --git a/txnbuild/create_account.go b/txnbuild/create_account.go
@@ -34,7 +34,9 @@ func (ca *CreateAccount) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, ca.SourceAccount)
+	if err = SetOpSourceAccount(&op, ca.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 
 	return op, nil
 }
diff --git a/txnbuild/create_claimable_balance.go b/txnbuild/create_claimable_balance.go
@@ -134,7 +134,9 @@ func (cb *CreateClaimableBalance) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, cb.SourceAccount)
+	if err = SetOpSourceAccount(&op, cb.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/create_passive_offer.go b/txnbuild/create_passive_offer.go
@@ -46,7 +46,9 @@ func (cpo *CreatePassiveSellOffer) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, cpo.SourceAccount)
+	if err = SetOpSourceAccount(&op, cpo.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 
 	return op, nil
 }
diff --git a/txnbuild/end_sponsoring_future_reserves.go b/txnbuild/end_sponsoring_future_reserves.go
@@ -21,7 +21,9 @@ func (es *EndSponsoringFutureReserves) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, es.SourceAccount)
+	if err = SetOpSourceAccount(&op, es.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 
 	return op, nil
 }
diff --git a/txnbuild/extend_footprint_ttl.go b/txnbuild/extend_footprint_ttl.go
@@ -26,7 +26,9 @@ func (f *ExtendFootprintTtl) BuildXDR() (xdr.Operation, error) {
 
 	op := xdr.Operation{Body: body}
 
-	SetOpSourceAccount(&op, f.SourceAccount)
+	if err = SetOpSourceAccount(&op, f.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/inflation.go b/txnbuild/inflation.go
@@ -19,7 +19,9 @@ func (inf *Inflation) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, inf.SourceAccount)
+	if err = SetOpSourceAccount(&op, inf.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/invoke_host_function.go b/txnbuild/invoke_host_function.go
@@ -237,7 +237,9 @@ func (f *InvokeHostFunction) BuildXDR() (xdr.Operation, error) {
 
 	op := xdr.Operation{Body: body}
 
-	SetOpSourceAccount(&op, f.SourceAccount)
+	if err = SetOpSourceAccount(&op, f.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/liquidity_pool_deposit.go b/txnbuild/liquidity_pool_deposit.go
@@ -78,7 +78,9 @@ func (lpd *LiquidityPoolDeposit) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, lpd.SourceAccount)
+	if err = SetOpSourceAccount(&op, lpd.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/liquidity_pool_withdraw.go b/txnbuild/liquidity_pool_withdraw.go
@@ -79,7 +79,9 @@ func (lpd *LiquidityPoolWithdraw) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, lpd.SourceAccount)
+	if err = SetOpSourceAccount(&op, lpd.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/manage_buy_offer.go b/txnbuild/manage_buy_offer.go
@@ -48,7 +48,9 @@ func (mo *ManageBuyOffer) BuildXDR() (xdr.Operation, error) {
 	}
 
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, mo.SourceAccount)
+	if err = SetOpSourceAccount(&op, mo.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/manage_data.go b/txnbuild/manage_data.go
@@ -31,7 +31,9 @@ func (md *ManageData) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, md.SourceAccount)
+	if err = SetOpSourceAccount(&op, md.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/manage_offer.go b/txnbuild/manage_offer.go
@@ -115,7 +115,9 @@ func (mo *ManageSellOffer) BuildXDR() (xdr.Operation, error) {
 	}
 
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, mo.SourceAccount)
+	if err = SetOpSourceAccount(&op, mo.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/operation.go b/txnbuild/operation.go
@@ -3,6 +3,7 @@ package txnbuild
 import (
 	"fmt"
 
+	"github.com/stellar/go-stellar-sdk/support/errors"
 	"github.com/stellar/go-stellar-sdk/xdr"
 )
 
@@ -15,13 +16,17 @@ type Operation interface {
 }
 
 // SetOpSourceAccount sets the source account ID on an Operation, allowing M-strkeys (as defined in SEP23).
-func SetOpSourceAccount(op *xdr.Operation, sourceAccount string) {
+func SetOpSourceAccount(op *xdr.Operation, sourceAccount string) error {
 	if sourceAccount == "" {
-		return
+		return nil
 	}
 	var opSourceAccountID xdr.MuxedAccount
-	opSourceAccountID.SetAddress(sourceAccount)
+	err := opSourceAccountID.SetAddress(sourceAccount)
+	if err != nil {
+		return errors.Wrap(err, "failed to set op source account")
+	}
 	op.SourceAccount = &opSourceAccountID
+	return nil
 }
 
 // operationFromXDR returns a txnbuild Operation from its corresponding XDR operation
diff --git a/txnbuild/path_payment.go b/txnbuild/path_payment.go
@@ -88,7 +88,9 @@ func (pp *PathPaymentStrictReceive) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, pp.SourceAccount)
+	if err = SetOpSourceAccount(&op, pp.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/path_payment_strict_send.go b/txnbuild/path_payment_strict_send.go
@@ -82,7 +82,9 @@ func (pp *PathPaymentStrictSend) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, pp.SourceAccount)
+	if err = SetOpSourceAccount(&op, pp.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/payment.go b/txnbuild/payment.go
@@ -49,7 +49,9 @@ func (p *Payment) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR Operation")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, p.SourceAccount)
+	if err = SetOpSourceAccount(&op, p.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/restore_footprint.go b/txnbuild/restore_footprint.go
@@ -97,7 +97,9 @@ func (f *RestoreFootprint) BuildXDR() (xdr.Operation, error) {
 
 	op := xdr.Operation{Body: body}
 
-	SetOpSourceAccount(&op, f.SourceAccount)
+	if err = SetOpSourceAccount(&op, f.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/revoke_sponsorship.go b/txnbuild/revoke_sponsorship.go
@@ -153,7 +153,9 @@ func (r *RevokeSponsorship) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, r.SourceAccount)
+	if err = SetOpSourceAccount(&op, r.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 
 	return op, nil
 }
diff --git a/txnbuild/set_options.go b/txnbuild/set_options.go
@@ -95,7 +95,9 @@ func (so *SetOptions) BuildXDR() (xdr.Operation, error) {
 	}
 
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, so.SourceAccount)
+	if err = SetOpSourceAccount(&op, so.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 
diff --git a/txnbuild/set_trust_line_flags.go b/txnbuild/set_trust_line_flags.go
@@ -57,7 +57,9 @@ func (stf *SetTrustLineFlags) BuildXDR() (xdr.Operation, error) {
 		return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")
 	}
 	op := xdr.Operation{Body: body}
-	SetOpSourceAccount(&op, stf.SourceAccount)
+	if err = SetOpSourceAccount(&op, stf.SourceAccount); err != nil {
+		return xdr.Operation{}, err
+	}
 	return op, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,9 @@ func (am *AccountMerge) BuildXDR() (xdr.Operation, error) {`
`26`	`26`	`return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")`
`27`	`27`	`}`
`28`	`28`	`op := xdr.Operation{Body: body}`
`29`		`- SetOpSourceAccount(&op, am.SourceAccount)`
	`29`	`+ if err = SetOpSourceAccount(&op, am.SourceAccount); err != nil {`
	`30`	`+ return xdr.Operation{}, err`
	`31`	`+ }`
`30`	`32`	`return op, nil`
`31`	`33`	`}`
`32`	`34`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,9 @@ func (at *AllowTrust) BuildXDR() (xdr.Operation, error) {`
`56`	`56`	`return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")`
`57`	`57`	`}`
`58`	`58`	`op := xdr.Operation{Body: body}`
`59`		`- SetOpSourceAccount(&op, at.SourceAccount)`
	`59`	`+ if err = SetOpSourceAccount(&op, at.SourceAccount); err != nil {`
	`60`	`+ return xdr.Operation{}, err`
	`61`	`+ }`
`60`	`62`	`return op, nil`
`61`	`63`	`}`
`62`	`64`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,9 @@ func (bs *BeginSponsoringFutureReserves) BuildXDR() (xdr.Operation, error) {`
`27`	`27`	`return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")`
`28`	`28`	`}`
`29`	`29`	`op := xdr.Operation{Body: body}`
`30`		`- SetOpSourceAccount(&op, bs.SourceAccount)`
	`30`	`+ if err = SetOpSourceAccount(&op, bs.SourceAccount); err != nil {`
	`31`	`+ return xdr.Operation{}, err`
	`32`	`+ }`
`31`	`33`	`return op, nil`
`32`	`34`	`}`
`33`	`35`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,9 @@ func (bs *BumpSequence) BuildXDR() (xdr.Operation, error) {`
`21`	`21`	`return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")`
`22`	`22`	`}`
`23`	`23`	`op := xdr.Operation{Body: body}`
`24`		`- SetOpSourceAccount(&op, bs.SourceAccount)`
	`24`	`+ if err = SetOpSourceAccount(&op, bs.SourceAccount); err != nil {`
	`25`	`+ return xdr.Operation{}, err`
	`26`	`+ }`
`25`	`27`	`return op, nil`
`26`	`28`	`}`
`27`	`29`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,9 @@ func (ct *ChangeTrust) BuildXDR() (xdr.Operation, error) {`
`58`	`58`	`return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")`
`59`	`59`	`}`
`60`	`60`	`op := xdr.Operation{Body: body}`
`61`		`- SetOpSourceAccount(&op, ct.SourceAccount)`
	`61`	`+ if err = SetOpSourceAccount(&op, ct.SourceAccount); err != nil {`
	`62`	`+ return xdr.Operation{}, err`
	`63`	`+ }`
`62`	`64`	`return op, nil`
`63`	`65`	`}`
`64`	`66`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,9 @@ func (cb *ClaimClaimableBalance) BuildXDR() (xdr.Operation, error) {`
`31`	`31`	`return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")`
`32`	`32`	`}`
`33`	`33`	`op := xdr.Operation{Body: body}`
`34`		`- SetOpSourceAccount(&op, cb.SourceAccount)`
	`34`	`+ if err = SetOpSourceAccount(&op, cb.SourceAccount); err != nil {`
	`35`	`+ return xdr.Operation{}, err`
	`36`	`+ }`
`35`	`37`
`36`	`38`	`return op, nil`
`37`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,9 @@ func (cb *Clawback) BuildXDR() (xdr.Operation, error) {`
`54`	`54`	`return xdr.Operation{}, errors.Wrap(err, "failed to build XDR Operation")`
`55`	`55`	`}`
`56`	`56`	`op := xdr.Operation{Body: body}`
`57`		`- SetOpSourceAccount(&op, cb.SourceAccount)`
	`57`	`+ if err = SetOpSourceAccount(&op, cb.SourceAccount); err != nil {`
	`58`	`+ return xdr.Operation{}, err`
	`59`	`+ }`
`58`	`60`	`return op, nil`
`59`	`61`	`}`
`60`	`62`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,9 @@ func (cb *ClawbackClaimableBalance) BuildXDR() (xdr.Operation, error) {`
`30`	`30`	`return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")`
`31`	`31`	`}`
`32`	`32`	`op := xdr.Operation{Body: body}`
`33`		`- SetOpSourceAccount(&op, cb.SourceAccount)`
	`33`	`+ if err = SetOpSourceAccount(&op, cb.SourceAccount); err != nil {`
	`34`	`+ return xdr.Operation{}, err`
	`35`	`+ }`
`34`	`36`
`35`	`37`	`return op, nil`
`36`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,9 @@ func (ca *CreateAccount) BuildXDR() (xdr.Operation, error) {`
`34`	`34`	`return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")`
`35`	`35`	`}`
`36`	`36`	`op := xdr.Operation{Body: body}`
`37`		`- SetOpSourceAccount(&op, ca.SourceAccount)`
	`37`	`+ if err = SetOpSourceAccount(&op, ca.SourceAccount); err != nil {`
	`38`	`+ return xdr.Operation{}, err`
	`39`	`+ }`
`38`	`40`
`39`	`41`	`return op, nil`
`40`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,9 @@ func (cb *CreateClaimableBalance) BuildXDR() (xdr.Operation, error) {`
`134`	`134`	`return xdr.Operation{}, errors.Wrap(err, "failed to build XDR OperationBody")`
`135`	`135`	`}`
`136`	`136`	`op := xdr.Operation{Body: body}`
`137`		`- SetOpSourceAccount(&op, cb.SourceAccount)`
	`137`	`+ if err = SetOpSourceAccount(&op, cb.SourceAccount); err != nil {`
	`138`	`+ return xdr.Operation{}, err`
	`139`	`+ }`
`138`	`140`	`return op, nil`
`139`	`141`	`}`
`140`	`142`