Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set keyEquivalent for "Apply" button #13

Open
dehlen opened this issue Feb 5, 2020 · 0 comments
Open

Set keyEquivalent for "Apply" button #13

dehlen opened this issue Feb 5, 2020 · 0 comments

Comments

@dehlen
Copy link
Contributor

dehlen commented Feb 5, 2020

The "Apply" button in the preferences dialog is missing a key equivalent. If this is set to "\r" the button will automatically displayed blue and its action is triggered on return. This is the default for primary buttons on macOS. I am not sure however if SwiftUI is supporting this, which is why I build a MacButton NSViewRepresentable for it. Let me know what you think, so we can discuss this further.

We might be able to remove the "Apply" Button altogether. Is there anything stopping you from storing the entered values as they change/onEndEditing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant