Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No fee validation and no network is displayed on confirmation screen when sending collectible from account with 0 eth #22213

Open
pavloburykh opened this issue Feb 28, 2025 · 1 comment
Labels
wallet: Collectibles all issues for the collectibles page of the wallet wallet-core Issues for mobile wallet team
Milestone

Comments

@pavloburykh
Copy link
Contributor

pavloburykh commented Feb 28, 2025

Preconditions: User has Account A which holds some collectibles but 0 eth (no eth to cover fee)

Steps:

  1. Initiate collectible send flow from Account A
  2. Proceed to confirmation screen
  3. On confirmation screen pay attention if there is fee validation
  4. On confirmation screen pay attention if network is shown
  5. See if user can confirm transaction

Actual result:

  1. No fee validation, user can proceed with confirming transaction
  2. No network is shown on confirmation screen
  3. User can confirm transaction which will fail with fee error
  4. If transaction has been initiated from Overview screen, user will get additional re-matches must match against a string. error after confirming transaction and redirection to activity tab

See video below

telegram-cloud-document-2-5334661990826666368.mp4

Expected result:

  1. Fee validation should be shown, user shouldn't be able to proceed with confirming transaction
  2. Network should be shown on confirmation screen

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@pavloburykh pavloburykh added wallet: Collectibles all issues for the collectibles page of the wallet wallet-core Issues for mobile wallet team labels Feb 28, 2025
@pavloburykh pavloburykh changed the title No fee validation when sending collectible from account with 0 eth No fee validation and no network is displayed on confirmation screen when sending collectible from account with 0 eth Feb 28, 2025
@pavloburykh pavloburykh added this to the 2.34.0 milestone Feb 28, 2025
@pavloburykh pavloburykh moved this from Backlog to Next in Status Desktop/Mobile Board Feb 28, 2025
@pavloburykh
Copy link
Contributor Author

Added to 2.34 milestone with Critical impact based on discussion with @shivekkhurana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wallet: Collectibles all issues for the collectibles page of the wallet wallet-core Issues for mobile wallet team
Projects
Status: Next
Development

No branches or pull requests

1 participant