Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not implement design for Swap sign transaction screen #22211

Open
Horupa-Olena opened this issue Feb 28, 2025 · 1 comment
Open

Not implement design for Swap sign transaction screen #22211

Horupa-Olena opened this issue Feb 28, 2025 · 1 comment
Assignees
Labels
ui-polish Aesthetics; not a functional bug wallet: swap wallet-core Issues for mobile wallet team

Comments

@Horupa-Olena
Copy link

Horupa-Olena commented Feb 28, 2025

Bug Report

Problem

Current design for Swap sign screen is broken.
Not implement new design for Swap sign transaction screen.
Also design not updates in Figma.

Reproduction

  1. Initiate Swap flow
  2. Navigate to Sign transaction screen and observe

Expected behavior

Design must look like in design.

Actual behavior

  1. Inconsistency in design file in Figma
  2. Missing borders and margin in current version this screen
App Design (dark theme) Design (light theme)
Image Image Image

Additional Information

Design for light theme: https://www.figma.com/design/AD2JSKg0I8dZcylyiGa62O/Swap-for-Mobile?node-id=50-87010&t=fjMMQ3zErevULFn5-0

Design for dark theme: https://www.figma.com/design/AD2JSKg0I8dZcylyiGa62O/Swap-for-Mobile?node-id=149-30563&t=fjMMQ3zErevULFn5-0

  • Status version: release build
  • Operating System: Android, iOS

Acceptance criteria

  • Margins are added on swap screen OR the design is the same as defined on Design (light theme)
  • No overlapped arrow when biometric auth is enabled or it is keycard account (details here )
@Horupa-Olena Horupa-Olena added wallet: swap wallet-core Issues for mobile wallet team ui-polish Aesthetics; not a functional bug labels Feb 28, 2025
@churik
Copy link
Member

churik commented Feb 28, 2025

On accounts with keycard and biometric authentication the arrow is overlapped with other icon:
Image

@alwx alwx self-assigned this Feb 28, 2025
@churik churik moved this to In Progress in Status Desktop/Mobile Board Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-polish Aesthetics; not a functional bug wallet: swap wallet-core Issues for mobile wallet team
Projects
Status: In Progress
Development

No branches or pull requests

3 participants