Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#22206] fix: swap proposal keep sending update either after clean up #22212

Open
wants to merge 1 commit into
base: release/2.33.x
Choose a base branch
from
Open

[#22206] fix: swap proposal keep sending update either after clean up #22212

wants to merge 1 commit into from

Conversation

mohsen-ghafouri
Copy link
Contributor

fixes #22206

Summary

swap proposal keep sending update either after clean up

Areas that may be impacted

  • Swap

Precondition:

  1. The app should remain in the background for approximately 1 hour or more.
  2. 1–2 profiles with assets should be added to the app.

Reproduction

  1. Resume the app from the background
  2. Login to the Profile 1
  3. Go to Wallet -> Swap
  4. Choose networks and enter amount (no matter what data you choose)
  5. Tap on max slippage
  6. Do some changes there
  7. Leave Swap and do a log out

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Feb 28, 2025
@mohsen-ghafouri mohsen-ghafouri added the wallet-core Issues for mobile wallet team label Feb 28, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Feb 28, 2025 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e641277 #1 2025-02-28 11:14:33 ~4 min tests 📄log
✔️ e641277 #1 2025-02-28 11:18:11 ~8 min android-e2e 🤖apk 📲
✔️ e641277 #1 2025-02-28 11:18:42 ~8 min android 🤖apk 📲
✔️ d861934 #4 2025-02-28 11:28:03 ~7 min tests 📄log
✔️ d861934 #4 2025-02-28 11:28:34 ~7 min android-e2e 🤖apk 📲
✔️ d861934 #4 2025-02-28 11:31:21 ~10 min android 🤖apk 📲
✔️ d861934 #4 2025-02-28 11:32:33 ~11 min ios 📱ipa 📲

@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/database-closed-error branch from e641277 to f5e3aeb Compare February 28, 2025 11:18
@mohsen-ghafouri mohsen-ghafouri changed the base branch from develop to release/2.33.x February 28, 2025 11:18
@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/database-closed-error branch from f5e3aeb to d861934 Compare February 28, 2025 11:20
@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 14
Failed tests: 1
Expected to fail tests: 0
Passed tests: 13

IDs of failed tests: 741839

Failed tests (1)

Click to expand
  • Rerun failed tests

    • Class TestWalletCollectibles:

    1. test_wallet_collectibles_balance, id: 741839

    # STEP: Check BVL collectible info and image
    # STEP: Check Glitch Punks collectible info and image

    critical/wallet/test_collectibles.py:94: in test_wallet_collectibles_balance
    self.errors.verify_no_errors()
base_test_case.py:179: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Device 1: Collectible 'BVL' is not displayed
E    Device 1: Collectible 'Glitch Punks' is not displayed



    Passed tests (13)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestWalletOneDevice:

    1. test_wallet_swap_flow_mainnet, id: 741555
    2. test_wallet_add_remove_regular_account, id: 727231
    3. test_wallet_balance_mainnet, id: 740490
    4. test_wallet_bridge_flow_mainnet, id: 741612
    5. test_wallet_send_flow_mainnet, id: 741554

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletCollectibles:

    1. test_wallet_send_collectible, id: 741840
    2. test_wallet_collectible_send_from_expanded_info_view, id: 741841

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    @mariia-skrypnyk mariia-skrypnyk self-assigned this Feb 28, 2025
    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 1
Failed tests: 1
Expected to fail tests: 0
Passed tests: 0

    IDs of failed tests: 741839

    Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestWalletCollectibles:

    1. test_wallet_collectibles_balance, id: 741839

    # STEP: Check BVL collectible info and image
    # STEP: Check Glitch Punks collectible info and image

    critical/wallet/test_collectibles.py:94: in test_wallet_collectibles_balance
    self.errors.verify_no_errors()
base_test_case.py:179: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Device 1: Collectible 'BVL' is not displayed
E    Device 1: Collectible 'Glitch Punks' is not displayed



    @mariia-skrypnyk
    Copy link

    Hi @mohsen-ghafouri !

    Thanks for your fix.

    I do not observe the issue with error anymore.
    PR can be merged.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @vkjr vkjr vkjr approved these changes

    @shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @clauxx clauxx Awaiting requested review from clauxx

    @jakubgs jakubgs Awaiting requested review from jakubgs

    Assignees

    @mohsen-ghafouri mohsen-ghafouri

    @mariia-skrypnyk mariia-skrypnyk

    Labels
    request-manual-qa Tested - OK wallet-core Issues for mobile wallet team
    Projects
    Pipeline for QA
    Status: E2E Tests
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    "sql: database is closed" toast appears every 5 seconds after Profile log out
    4 participants
    @mohsen-ghafouri @status-im-auto @mariia-skrypnyk @vkjr