Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unknown asset is shown in the "assets to receive" field when opening swap via long tap #22188

Open
VolodLytvynenko opened this issue Feb 25, 2025 · 6 comments
Assignees
Milestone

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Feb 25, 2025

Unfortunately, this issue doesn't happen consistently, and there are no exact steps to reproduce it. Hopefully, the logs will help

Steps to reproduce:

  1. Restore or create empty user (without tokens)
  2. Import account with ETH
  3. Open the Wallet main page with available ETH.
  4. Long-tap on an asset → Tap "Swap" → Navigate to the Swap page.

Actual result:

The unknown asset is shown in the "Assets to Receive" field instead of USDC.

snt_instead_usdc.mp4

Expected result:

USDC should be displayed in the "Assets to Receive" field.

Devices:

Pixel 7a (Android 13)
iPhone 11 Pro Max (iOS 17)

Logs:

Ios https://drive.google.com/file/d/1Np_GKn9KJuFGWIYP-fKsA2NbNTdbGOrw/view?usp=drive_link
Android https://drive.google.com/file/d/1gnk1qysmYX4JGyGZm1nMMa90jD5XC5e8/view?usp=drive_link

@VolodLytvynenko
Copy link
Contributor Author

VolodLytvynenko commented Feb 25, 2025

hi @mohsen-ghafouri seems I found the exact steps:

Steps to reproduce:

  1. Restore or create empty user (without tokens)
  2. Import account with ETH
  3. Open the Wallet main page
  4. Long-tap on an eth → Tap "Swap" → Navigate to the Swap page.
usdc_e.mp4

@mohsen-ghafouri mohsen-ghafouri self-assigned this Feb 25, 2025
@churik churik added this to the 2.34.0 milestone Feb 26, 2025
@VolodLytvynenko
Copy link
Contributor Author

@mohsen-ghafouri Unfortunately, the issue still exists, but this time, different steps were identified.

Steps:

  1. Restore user where ETH exists only on 1 network
  2. Go to swap page selecting ETH

Actual result:

swap_uknown.mp4

@mohsen-ghafouri
Copy link
Contributor

@VolodLytvynenko it seems there is no USDC to select, should i fallback to SNT in this case?

@VolodLytvynenko
Copy link
Contributor Author

@VolodLytvynenko it seems there is no USDC to select, should i fallback to SNT in this case?

@mohsen-ghafouri Yes, if this is a temporary solution, then it's fine. However, in the PR that aims to fully implement (this task ), it would be better to fix it properly.

As I understand it, the current PR is focused on fixing the Max value and the autofill behavior for ETH.

@mohsen-ghafouri
Copy link
Contributor

Yes, in that PR they might send USDC also as default asset so this error won't happen. temporary if USDC is not available i will fallback to SNT.

@mohsen-ghafouri
Copy link
Contributor

@VolodLytvynenko resolved, please check it again. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants