Integrate Firebase for Android and iOS #21983
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (83)
|
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
6 times, most recently
from
e49478b to
ca8441e
Compare
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
3 times, most recently
from
5307db3 to
be2a8c2
Compare
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
3 times, most recently
from
4453b01 to
f58e51a
Compare
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
2 times, most recently
from
fb74c25 to
6c73939
Compare
seanstrom
changed the title
seanstrom
commented
Feb 24, 2025
.env.jenkins
Outdated
Comment on lines
38
to
42
| FLAG_WALLET_CONNECT_ENABLED=1 | ||
| API_LOGGING_ENABLED=1 | ||
| GOOGLE_FREE=0 |
There was a problem hiding this comment.
Here we're adding a environment variable for configuring the build to avoid bundling Google dependencies for Firebase and Google Play Services.
Comment on lines
212
to
216
| build-fdroid: ##@build Build release for F-Droid | ||
| @scripts/google-free.sh | ||
| @scripts/build-android.sh | ||
|
|
There was a problem hiding this comment.
Here we're adding an additional script step for preparing an Android build for FDroid.
| @@ -1 +1 @@ | |||
| 2.32.0 | |||
| 2.32.21983 | |||
There was a problem hiding this comment.
This version change is temporary and should be removed before merge.
There was a problem hiding this comment.
This version change is used for creating a testable release builds via the PR number, and as a best practice we change the app version number so we don't conflicts with upcoming releases in the build pipeline.
android/app/build.gradle
Outdated
Comment on lines
86
to
90
| /** | ||
| * Exclude google library so we can publish to external android stores | ||
| */ | ||
| def googleFree = project.env.get("GOOGLE_FREE", 0) == '1' | ||
|
|
There was a problem hiding this comment.
Here we're accessing the environment variable from the Android build system (Gradle), and we use this flag to configure the build's dependencies.
android/app/build.gradle
Outdated
Comment on lines
298
to
311
| if (googleFree) { | ||
| implementation(project(':react-native-firebase_app')) { | ||
| exclude group: 'com.google.firebase' | ||
| exclude group: 'com.google.gms' | ||
| } | ||
|
|
||
| implementation(project(':react-native-firebase_messaging')) { | ||
| exclude group: 'com.google.firebase' | ||
| exclude group: 'com.google.gms' | ||
| } | ||
| } else { | ||
| implementation 'com.google.firebase:firebase-messaging:24.1.0' | ||
| } | ||
|
|
There was a problem hiding this comment.
Here we're attempting to exclude Firebase and Google dependencies from the app when attempting to build a FDroid build.
scripts/build-android.sh
Outdated
Comment on lines
57
to
62
| # Used by Clojure at compile time for remove import of firebase for fdroid release | ||
| if [[ -n "${READER_FEATURES}" ]]; then | ||
| append_env_export 'READER_FEATURES' | ||
| fi | ||
|
|
There was a problem hiding this comment.
Here we're integrating with ShadowCLJS during the Android build to forward the GOOGLE_FREE flag as a reader conditional. This allows us to conditionally include Firebase dependencies in JavaScript bundle.
Comment on lines
+1
to
+11
| #!/usr/bin/env bash | ||
|
|
||
| set -e | ||
|
|
||
| # Used by Clojure to condition code and Gradle to make dependencies optional | ||
| sed -i -e '$aGOOGLE_FREE=1' .env.release | ||
|
|
||
| # remove firebase (uses google dependencies) and google-services.json for the fdroid-build | ||
| yarn remove @react-native-firebase/app | ||
| yarn remove @react-native-firebase/messaging | ||
| rm android/app/google-services.json |
There was a problem hiding this comment.
Here we're defining a cleanup script for the FDroid builds that removes Firebase dependencies and related files before continuing with building Android app for FDroid.
shadow-cljs.edn
Outdated
Comment on lines
110
to
112
| :reader-features #{:mobile | ||
| #shadow/env ["READER_FEATURES" :as :keyword :default | ||
| :cljs]}} |
There was a problem hiding this comment.
Here we're configuring ShadowCLJS mobile build with the extra reader conditional flags.
src/status_im/feature_flags.cljs
Outdated
Comment on lines
19
to
24
| ::profile-pictures-visibility (enabled-in-env? :FLAG_PROFILE_PICTURES_VISIBILITY_ENABLED) | ||
| ::settings.import-all-keypairs (enabled-in-env? :FLAG_WALLET_SETTINGS_IMPORT_ALL_KEYPAIRS) | ||
| ::settings.remote-notifications (enabled-in-env? :FLAG_NOTIFICATION_SETTINGS_REMOTE_NOTIFICATIONS) | ||
| ::wallet.add-watched-address (enabled-in-env? :FLAG_ADD_WATCHED_ADDRESS) |
There was a problem hiding this comment.
Here we're adding the feature flag for the remote notifications toggle.
src/react_native/firebase.cljc
Outdated
Comment on lines
1
to
11
| (ns react-native.firebase | ||
| (:require | ||
| #?@(:google-free | ||
| [[react-native.firebase.firebase-fdroid]] | ||
| :cljs | ||
| [[react-native.firebase.firebase-google]]))) | ||
|
|
||
| #?(:google-free | ||
| [(def request-remote-token react-native.firebase.firebase-fdroid/request-remote-token)] | ||
| :cljs | ||
| [(def request-remote-token react-native.firebase.firebase-google/request-remote-token)]) |
There was a problem hiding this comment.
Here we're using the ShadowCLJS reader conditionals to avoid requiring the Firebase bindings and dependencies when building for FDroid.
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
from
d455ee1 to
9173de4
Compare
…when enabling remote notifications
…istration for ios
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
from
9173de4 to
a13ab31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #22090
resolves #22174
Summary
Review notes
make cleanbefore rebuilding the app.Testing notes
Platforms
Areas that may be impacted
Functional
Steps to test
WIP
status: ready