Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slide-button not resetting #22210

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix slide-button not resetting #22210

wants to merge 1 commit into from
+11 −12

Conversation

clauxx
Copy link
Member

@clauxx clauxx commented Feb 28, 2025

fixes #22163

Summary

Since some usages of the slide button were moved from the standard-auth to the simpler quo version, the resetting of the slider should be moved to the quo component as well. It's not used without resetting anyways (nor should it, since it leads to broken behavior).

Testing notes

The changes are in the slide-button component, specifically the resetting of the slider. Need to make sure we have no places where the slide-button shouldn't reset automatically after completing the slide (500 ms timeout), but I didn't find any so far.

status: ready

@clauxx clauxx self-assigned this Feb 28, 2025
@clauxx clauxx added the wallet-core Issues for mobile wallet team label Feb 28, 2025
@clauxx clauxx added this to the 2.33.0 milestone Feb 28, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Feb 28, 2025 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 105145b #1 2025-02-28 10:27:17 ~4 min tests 📄log
✔️ 105145b #1 2025-02-28 10:29:32 ~6 min android-e2e 🤖apk 📲
✔️ 105145b #1 2025-02-28 10:30:19 ~7 min android 🤖apk 📲
✔️ 105145b #1 2025-02-28 10:34:17 ~11 min ios 📱ipa 📲

mohsen-ghafouri
mohsen-ghafouri approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clauxx
Copy link
Member Author

clauxx commented Feb 28, 2025

@status-im/mobile-qa ready for testing

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 14
Failed tests: 0
Expected to fail tests: 0
Passed tests: 14

Passed tests (14)

Click to expand

Class TestWalletCollectibles:

1. test_wallet_send_collectible, id: 741840
2. test_wallet_collectibles_balance, id: 741839
3. test_wallet_collectible_send_from_expanded_info_view, id: 741841

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

Class TestWalletOneDevice:

1. test_wallet_swap_flow_mainnet, id: 741555
2. test_wallet_add_remove_regular_account, id: 727231
3. test_wallet_balance_mainnet, id: 740490
4. test_wallet_bridge_flow_mainnet, id: 741612
5. test_wallet_send_flow_mainnet, id: 741554

@churik churik self-assigned this Feb 28, 2025
@churik
Copy link
Member

churik commented Feb 28, 2025

Tested Scenarios:

✔ Swap - Send - Bridge - Dapp sign Flow with keycard: Verified functionality across different interruption points
✔ Incorrect KeyCard Usage: Tested applying an incorrect card at sign step
✔ Flow Interruptions: Checked behavior when the process was disrupted at different stages.
✔ Regression Testing:
• Incorrect password handling
• interruptions with password-biometric authentication

Results:

🔹 No bugs found 🎉

@clauxx beautiful work!

Can you please make sure that it is cherrypicked to release branch or ask @vkjr to pick it?
Now we changes process a bit and basing bugfixes on release branch initially, but I do not think it matters now.

@clauxx
Copy link
Member Author

clauxx commented Feb 28, 2025

@churik @vkjr what do now? 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivekkhurana shivekkhurana shivekkhurana approved these changes

@smohamedjavid smohamedjavid smohamedjavid approved these changes

@mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes

@alwx alwx Awaiting requested review from alwx

@vkjr vkjr Awaiting requested review from vkjr

Assignees

@churik churik

@clauxx clauxx

Labels
request-manual-qa Tested - OK wallet-core Issues for mobile wallet team
Projects
Pipeline for QA
Status: MERGE
Milestone
2.33.0
Development

Successfully merging this pull request may close these issues.

Keycard drawer does not reopen after being closed during transaction signing
6 participants
@clauxx @status-im-auto @churik @shivekkhurana @smohamedjavid @mohsen-ghafouri