Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect currency rounding #22162

Open
VolodLytvynenko opened this issue Feb 19, 2025 · 0 comments
Open

incorrect currency rounding #22162

VolodLytvynenko opened this issue Feb 19, 2025 · 0 comments
Labels
design-review-required wallet: Settings All issues for the mobile wallet settings wallet-core Issues for mobile wallet team

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Feb 19, 2025

Problem:

In the app, some price values are rounded to <0.01 or to 0.00 when they are less than 0.01, which makes it harder for users to see exact amounts. however, some wallets like TrustWallet make it without rounding:

Image

while this rule might be reasonable for the main wallet screen, there are cases where users would prefer to see precise amounts—especially for fees when dealing

Steps:

  1. Go to profile -> select currency which your user owns less than 0.01

Actual result:

  1. Wallet main page (rounded to 0.00 if a user has less than 0.01)
    Image

  2. Wallet list of assets (rounded to <0.01 if a user has less than 0.01)
    Image

  3. Network drawer (rounded to <0.01 if a user has less than 0.01)
    Image

  4. Value within routes set up a page (rounded to 0.00 if a user has less than 0.01)
    Image

  5. Fee estimation (rounded to <0.01 if a user has less than 0.01)
    Image

Expected result:

If the selected current is crypto and is higher than USD fiat, then the following rule should be applied:

NOTE:

Discussing it with the design team https://discord.com/channels/1210237582470807632/1274068685266489434/1341781803723395215

@VolodLytvynenko VolodLytvynenko added the wallet-core Issues for mobile wallet team label Feb 19, 2025
@VolodLytvynenko VolodLytvynenko added design-review-required wallet: Settings All issues for the mobile wallet settings labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-review-required wallet: Settings All issues for the mobile wallet settings wallet-core Issues for mobile wallet team
Projects
Status: Backlog
Development

No branches or pull requests

1 participant