[6.x] Fix default: now on date fields
#13044
Open
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that when we get midnight, we're getting midnight in the user's timezone and not midnight in UTC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with
default: nowon Date fields (we usedefault: nowon dated entries).Currently, the date fieldtype's
preProcessmethod returns the current time in UTC. This works fine whentime_enabled: true.However, when it is
false, we need to get midnight in the client's timezone, which we can only do in JavaScript. We can re-use theaddDatemethod for this (it's currently used when you click "Add Date" on an optional date field).Because setting the field's value will make the page dirty, I've added a line to ensure the publish container's dirty state is cleared on the next tick, avoiding unnecessary dirty state warnings.
Fixes #12585