From acb8235563967a06439ab0bdcf645ccccb651c94 Mon Sep 17 00:00:00 2001 From: Duncan McClean Date: Tue, 12 Nov 2024 11:07:55 +0000 Subject: [PATCH 1/4] Add PHP 8.4 to the testing matrix --- .github/workflows/tests.yml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 22f5f16056..601581fe56 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -16,10 +16,10 @@ jobs: strategy: matrix: - php: [8.1, 8.2, 8.3] - laravel: [10.*, 11.*] - stability: [prefer-lowest, prefer-stable] - os: [ubuntu-latest] + php: [ 8.1, 8.2, 8.3, 8.4 ] + laravel: [ 10.*, 11.* ] + stability: [ prefer-lowest, prefer-stable ] + os: [ ubuntu-latest ] include: - os: windows-latest php: 8.3 @@ -32,6 +32,8 @@ jobs: exclude: - php: 8.1 laravel: 11.* + - php: 8.4 + laravel: 10.* name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }} @@ -146,7 +148,7 @@ jobs: slack: name: Slack Notification runs-on: ubuntu-20.04 - needs: [php-tests, js-tests] + needs: [ php-tests, js-tests ] if: always() steps: - uses: technote-space/workflow-conclusion-action@v3 From 1fa1fd19ed05d8b916c3adfe9306c1ecc248855f Mon Sep 17 00:00:00 2001 From: Duncan McClean Date: Tue, 12 Nov 2024 11:09:07 +0000 Subject: [PATCH 2/4] Make PHPUnit display any deprecations --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 601581fe56..cbe63191bc 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -100,7 +100,7 @@ jobs: - name: Execute tests if: steps.should-run-tests.outputs.result == 'true' - run: vendor/bin/phpunit + run: vendor/bin/phpunit --display-deprecations js-tests: runs-on: ubuntu-20.04 From e20a56209363516708e2a5903cf1d1ed886cb80d Mon Sep 17 00:00:00 2001 From: Duncan McClean Date: Tue, 12 Nov 2024 11:10:49 +0000 Subject: [PATCH 3/4] Update `laravel/framework` version constraint --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index cbe63191bc..cae43a12bb 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -17,7 +17,7 @@ jobs: strategy: matrix: php: [ 8.1, 8.2, 8.3, 8.4 ] - laravel: [ 10.*, 11.* ] + laravel: [ 10.*, dev-php84-support ] stability: [ prefer-lowest, prefer-stable ] os: [ ubuntu-latest ] include: From 70fb20ccedf59130c8020718b0b693cba1b5596c Mon Sep 17 00:00:00 2001 From: Duncan McClean Date: Tue, 12 Nov 2024 11:19:13 +0000 Subject: [PATCH 4/4] wip --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index cae43a12bb..cbe63191bc 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -17,7 +17,7 @@ jobs: strategy: matrix: php: [ 8.1, 8.2, 8.3, 8.4 ] - laravel: [ 10.*, dev-php84-support ] + laravel: [ 10.*, 11.* ] stability: [ prefer-lowest, prefer-stable ] os: [ ubuntu-latest ] include: