Description 📹
Add network-level cron configuration to automatically refresh user configs
Currently, the cron system only refreshes user configs based on the refreshInCron property defined at the starky module level. This issue proposes adding a network-level cron configuration that allows networks to specify whether their configs should be refreshed periodically, while still respecting the existing module-level refresh settings.
The enhancement would add a cron boolean property to network configurations in configs/networks.json. When set to true, user configs using that network would be refreshed during the cron job execution, but ONLY if the corresponding starky module also has refreshInCron set to true. This ensures both conditions must be met for automatic refresh to occur.
(Currently no configs have the cron enabled, but you can change that to do your tests)
Proposed Actions 🛠️
Here's a checklist of actions to follow for resolving this issue:
- Fork and Create Branch:
Fork the repository and create a new branch using the issue number:
git checkout -b fix-[issue-number]
- Implement Changes:
- Run Tests and Commit Changes:
Make sure your changes don't break existing functionality and commit with a clear message:
git commit -m "Fix: Add network-level cron configuration with dual-condition refresh logic"
Required 📋
To keep our workflow smooth, please make sure you follow these guidelines:
- Assignment: Don't create a pull request if you weren't assigned to this issue.
- Timeframe: Complete the task within 3 business days.
- Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
- Review Process:
- Once you've submitted your PR, change the label to "ready for review".
- If changes are requested, address them and then update the label back to "ready for review" once done.
- Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.
Thank you for your contribution 🙏
⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.
Description 📹
Add network-level cron configuration to automatically refresh user configs
Currently, the cron system only refreshes user configs based on the
refreshInCronproperty defined at the starky module level. This issue proposes adding a network-level cron configuration that allows networks to specify whether their configs should be refreshed periodically, while still respecting the existing module-level refresh settings.The enhancement would add a
cronboolean property to network configurations inconfigs/networks.json. When set totrue, user configs using that network would be refreshed during the cron job execution, but ONLY if the corresponding starky module also hasrefreshInCronset totrue. This ensures both conditions must be met for automatic refresh to occur.(Currently no configs have the cron enabled, but you can change that to do your tests)
Proposed Actions 🛠️
Here's a checklist of actions to follow for resolving this issue:
Fork the repository and create a new branch using the issue number:
cronboolean property to network configuration type intypes/networks.tsconfigs/networks.jsonto includecronproperty for each network (default tofalse)cron.tsto check BOTH module-levelrefreshInCronAND network-levelcronsettingsrefreshDiscordServerfunction to filter configs where bothstarkyModule.refreshInCron === trueANDnetwork.cron === trueMake sure your changes don't break existing functionality and commit with a clear message:
git commit -m "Fix: Add network-level cron configuration with dual-condition refresh logic"Required 📋
To keep our workflow smooth, please make sure you follow these guidelines:
Thank you for your contribution 🙏