Skip to content

Commit 6dd9fd5

Browse files
committed
fix: remove secrets from e2e test suites
1 parent 0d37cb2 commit 6dd9fd5

File tree

6 files changed

+0
-34
lines changed

6 files changed

+0
-34
lines changed

.github/workflows/common-e2e.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,16 @@ on:
1111
type: string
1212
default: all
1313
description: The test suite to run
14-
secrets:
15-
DOCKER_USERNAME:
16-
required: true
17-
DOCKER_PASSWORD:
18-
required: true
19-
AWS_ACCESS_KEY_ID:
20-
required: true
21-
AWS_SECRET_ACCESS_KEY:
22-
required: true
2314

2415
jobs:
2516
e2e-self-hosted:
2617
uses: standardnotes/server/.github/workflows/e2e-self-hosted.yml@main
2718
with:
2819
snjs_image_tag: ${{ inputs.snjs_image_tag }}
2920
suite: ${{ inputs.suite }}
30-
secrets: inherit
3121

3222
e2e-home-server:
3323
uses: standardnotes/server/.github/workflows/e2e-home-server.yml@main
3424
with:
3525
snjs_image_tag: ${{ inputs.snjs_image_tag }}
3626
suite: ${{ inputs.suite }}
37-
secrets: inherit

.github/workflows/e2e-home-server.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,6 @@ on:
1111
type: string
1212
default: all
1313
description: The test suite to run
14-
secrets:
15-
DOCKER_USERNAME:
16-
required: true
17-
DOCKER_PASSWORD:
18-
required: true
19-
AWS_ACCESS_KEY_ID:
20-
required: true
21-
AWS_SECRET_ACCESS_KEY:
22-
required: true
2314

2415
jobs:
2516
e2e-home-server:

.github/workflows/e2e-self-hosted.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,6 @@ on:
1111
type: string
1212
default: all
1313
description: The test suite to run
14-
secrets:
15-
DOCKER_USERNAME:
16-
required: true
17-
DOCKER_PASSWORD:
18-
required: true
19-
AWS_ACCESS_KEY_ID:
20-
required: true
21-
AWS_SECRET_ACCESS_KEY:
22-
required: true
2314

2415
jobs:
2516
e2e:

.github/workflows/e2e-test-suite.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,3 @@ jobs:
3131
with:
3232
snjs_image_tag: ${{ inputs.snjs_image_tag || 'latest' }}
3333
suite: ${{ inputs.suite || 'all' }}
34-
secrets: inherit

.github/workflows/pr.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ jobs:
102102
with:
103103
snjs_image_tag: 'latest'
104104
suite: 'base'
105-
secrets: inherit
106105

107106
# e2e-vaults:
108107
# needs: build
@@ -111,4 +110,3 @@ jobs:
111110
# with:
112111
# snjs_image_tag: 'latest'
113112
# suite: 'vaults'
114-
# secrets: inherit

.github/workflows/publish.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ jobs:
102102
with:
103103
snjs_image_tag: 'latest'
104104
suite: 'base'
105-
secrets: inherit
106105

107106
# e2e-vaults:
108107
# needs: build
@@ -111,7 +110,6 @@ jobs:
111110
# with:
112111
# snjs_image_tag: 'latest'
113112
# suite: 'vaults'
114-
# secrets: inherit
115113

116114
publish-self-hosting:
117115
needs: [ test, lint, e2e-base ]

0 commit comments

Comments
 (0)