🐛: Zonefile not formatted for subdomains

[mitchplze]

What happened?

A bug happened! I think, anyways.

In this case, I think a picture is worth a thousand words.

The DNS record check in the table (first half) shows correctly for a subdomain, but the output zonefile at the bottom, does not generate with the subdomain included in the zonefile.

Instead, all are forced under the naked root domain. I am not super familiar with the DNS zonefile spec, but I believe this is incorrectly being generated in Stalwart, whenever a subdomain exists.

I only discovered this by accident when importing a zonefile to a DNS server without checking it, and it overwrote my production records, with something I was trying to test on a subdomain only. Oops.

How can we reproduce the problem?

I can reproduce the problem by doing the following steps:

Create a subdomain in Management > Directory > Domains
Goto "Check DNS records" screen

Observe zonefile generated at the bottom does not properly include subdomain

Version

v0.11.x

What database are you using?

RocksDB

What blob storage are you using?

RocksDB

Where is your directory located?

Internal

What operating system are you using?

Docker

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[mitchplze]

Quick note, when I export a known good zonefile (created in web UI) from Cloudflare DNS, they actually use fqdn with a trailing period. So this would seem to be a valid spec for zonefile and probably a safer implementation overall.