Skip to content

fix(clarity-cli): Make behavior of eval without .clar file less confusing #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjamin-stacks merged 1 commit into from
Dec 5, 2025
+14 −12
Merged

fix(clarity-cli): Make behavior of eval without .clar file less confusing #6738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"args": [
"build",
"--bin=clarity-cli",
"--package=stackslib"
"--package=clarity-cli"
],
"filter": {
"name": "clarity-cli",
Expand Down
24 changes: 13 additions & 11 deletions contrib/clarity-cli/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,14 +790,26 @@ impl HeadersDB for CLIHeadersDB {
fn get_eval_input(invoked_by: &str, args: &[String]) -> EvalInput {
if args.len() < 3 || args.len() > 4 {
eprintln!(
"Usage: {invoked_by} {} [--costs] [--epoch E] [--clarity_version N] [contract-identifier] (program.clar) [vm-state.db]",
"Usage: {invoked_by} {} [--costs] [--epoch E] [--clarity_version N] contract-identifier [program.clar] vm-state.db",
args[0]
);
eprintln!();
eprintln!(" If a program file name is not provided, the program is read from stdin.");
panic_test!();
}

let vm_filename = if args.len() == 3 { &args[2] } else { &args[3] };

let contract_identifier = friendly_expect(
QualifiedContractIdentifier::parse(&args[1]),
"Failed to parse contract identifier.",
);

let marf_kv = friendly_expect(
MarfedKV::open(vm_filename, None, None),
"Failed to open VM database.",
);

let content: String = {
if args.len() == 3 {
let mut buffer = String::new();
Expand All @@ -814,16 +826,6 @@ fn get_eval_input(invoked_by: &str, args: &[String]) -> EvalInput {
}
};

let contract_identifier = friendly_expect(
QualifiedContractIdentifier::parse(&args[1]),
"Failed to parse contract identifier.",
);

let marf_kv = friendly_expect(
MarfedKV::open(vm_filename, None, None),
"Failed to open VM database.",
);
// return (marf_kv, contract_identifier, vm_filename, content);
EvalInput {
marf_kv,
contract_identifier,
Expand Down