AAC: consensus tests for EarlyReturnError variants

[jacinta-stacks]

Closes #6702

[federico-stacks]

Just a quick note: this isn’t related to the PR itself, but something I noticed while reviewing it.

If I remember correctly, we had agreed to rename the variant ClarityError::Interpreter(VmExecutionError) to ClarityError::Execution(VmExecutionError). However, it’s still present as ClarityError::Interpreter.

Did we change our minds on that at some point (and I’m just forgetting), or did the rename simply never happen (or lost in one of many merge conflicts)?

@jacinta-stacks @francesco-stacks

[francesco-stacks]

there a problem with rust fmt. Apart from that everything looks good!

[francesco-stacks]

Just a quick note: this isn’t related to the PR itself, but something I noticed while reviewing it.

If I remember correctly, we had agreed to rename the variant ClarityError::Interpreter(VmExecutionError) to ClarityError::Execution(VmExecutionError). However, it’s still present as ClarityError::Interpreter.

Did we change our minds on that at some point (and I’m just forgetting), or did the rename simply never happen (or lost in one of many merge conflicts)?

@jacinta-stacks @francesco-stacks

The name didn't ring a bell, but I went through old conversations and files, and you are correct. It was once proposed to be renamed that way (by me D: ). I am not sure If I missed that during the renaming or there was another reason behind. Anyway, now that there are no other conflicting variants or enums with the same name, Interpreter doesnt' bother me very much, but I'd be supportive if you feel the name would be better

[jacinta-stacks]

Just a quick note: this isn’t related to the PR itself, but something I noticed while reviewing it.

If I remember correctly, we had agreed to rename the variant ClarityError::Interpreter(VmExecutionError) to ClarityError::Execution(VmExecutionError). However, it’s still present as ClarityError::Interpreter.

Did we change our minds on that at some point (and I’m just forgetting), or did the rename simply never happen (or lost in one of many merge conflicts)?

@jacinta-stacks @francesco-stacks

Yeah i thought for some reason it had been changed already but apparently not. I think it got lost in a merge as part of the VmExecution rename. But I am good either way.

[codecov]

Codecov Report

❌ Patch coverage is 69.84127% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.22%. Comparing base (cf8d685) to head (147105c).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ackslib/src/chainstate/tests/early_return_tests.rs	66.95%	38 Missing ⚠️

❌ Your project status has failed because the head coverage (73.22%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #6736       +/-   ##
============================================
+ Coverage    26.10%   73.22%   +47.12%     
============================================
  Files          579      580        +1     
  Lines       360068   360194      +126     
============================================
+ Hits         93986   263761   +169775     
+ Misses      266082    96433   -169649     

Files with missing lines	Coverage Δ
stackslib/src/chainstate/tests/consensus.rs	95.68% <100.00%> (+95.68%)	⬆️
stackslib/src/chainstate/tests/mod.rs	76.09% <ø> (+25.95%)	⬆️
...ackslib/src/chainstate/tests/early_return_tests.rs	66.95% <66.95%> (ø)

... and 517 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8d685...147105c. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[brice-stacks]

lgtm!