-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --version
arg to all buildable binaries
#5385
Comments
@wileyj - you can assign this to me |
its a little more complicated as it turns out: #5399 basically, updating cargo.toml won't work since we use a custom version string. i'd prefer to not have to update source code files with version either though. if you have a different idea (maybe a simple text file or yml that is read on compile?) i'd be interested though, and we can see what @hstove thinks |
@wileyj
Is this what you're wanting? For all the unchecked binaries to have a |
correct. additionally, there needs to be an easier way to set the version (in the linked PR, @hstove proposes updating the source files, but i think we can do it more simply like in a yaml or plain text. yaml sounds better to be honest). examplle of what this file may look like:
and if an env var is set, that should override the values in the file.
should override it any values in the yaml |
@wileyj - are you wanting the env var to be passed in the binary root build command or the monorepo root? Ie. Set the stacks-node version in its own build.rs or set all the versions from the root build.rs? |
I think a |
currently, only
stacks-node
andstacks-signer
respond to the--version
arg:All binaries should respond similarly to that arg.
The text was updated successfully, but these errors were encountered: