Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Implement validation of deposit fees in bitcoin transactions #802

Closed
1 task
djordon opened this issue Nov 9, 2024 · 0 comments · Fixed by #803
Closed
1 task

[Feature]: Implement validation of deposit fees in bitcoin transactions #802

djordon opened this issue Nov 9, 2024 · 0 comments · Fixed by #803
Assignees
Labels
sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Contributor

djordon commented Nov 9, 2024

Feature - Implement validation of deposit fees in bitcoin transactions

1. Description

Before a signer signs a bitcoin transaction they need to make sure that the fee associated with each deposit transaction input is below the associated max fee.

1.1 Context & Purpose

We need to respect the max-fee, and this is the signers' validation check.

2. Technical Details:

2.1 Acceptance Criteria:

  • We have code that validates an assessed fee against the max-fee.

3. Related Issues and Pull Requests (optional):

@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Nov 9, 2024
@djordon djordon added this to the sBTC: Deposit ready milestone Nov 9, 2024
@djordon djordon self-assigned this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant