Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]: Update Bridge to support deposit validation for create_deposit #1208

Open
3 tasks
Jiloc opened this issue Jan 13, 2025 · 0 comments
Open
3 tasks

[Chore]: Update Bridge to support deposit validation for create_deposit #1208

Jiloc opened this issue Jan 13, 2025 · 0 comments
Assignees
Labels
bridge web app The default web app for sBTC-v1. chore deposit The deposit sBTC operation.

Comments

@Jiloc
Copy link
Collaborator

Jiloc commented Jan 13, 2025

Chore - Update Bridge to support deposit validation for create_deposit

1. Description

Update the Bridge to support the new deposit validation requirements in the API as outlined in #1116 and implemented in PR #1197. Specifically, the Bridge must retrieve the full Bitcoin transaction as a hex-encoded string using OpenNode or Mempool APIs and include it in the transaction_hex field when calling the create_deposit endpoint.

Note that, once this is implemented, the Emily API will not return the right amount value from the create_deposit response.

2. Why It's Necessary

The updated API now requires a transaction_hex field to validate deposit requests, ensuring that only the depositor can inform the system of their deposits. Without this update to the Bridge, it will not comply with the new API requirements and deposit requests will fail.

3. Execution Checklist

  • Integrate OpenNode or Mempool API to retrieve the hex-encoded Bitcoin transaction.
  • Update the Bridge to include the transaction_hex field in requests to the create_deposit endpoint.
  • Test the implementation to ensure deposit requests are properly validated and accepted by the updated API.
@Jiloc Jiloc added bridge web app The default web app for sBTC-v1. deposit The deposit sBTC operation. chore labels Jan 13, 2025
@Jiloc Jiloc added this to sBTC Jan 13, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Jan 13, 2025
@djordon djordon moved this from Needs Triage to Todo in sBTC Jan 13, 2025
@setbern setbern self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge web app The default web app for sBTC-v1. chore deposit The deposit sBTC operation.
Projects
Status: Todo
Development

No branches or pull requests

3 participants