Clone the REST config to prevent data races in the k8s.io/cli-runtime library. (#26)

porridge · web-flow · commit be98f831243c · 2022-08-04T18:24:33.000+02:00
diff --git a/pkg/client/restclientgetter.go b/pkg/client/restclientgetter.go
@@ -48,7 +48,7 @@ type restClientGetter struct {
 }
 
 func (c *restClientGetter) ToRESTConfig() (*rest.Config, error) {
-	return c.restConfig, nil
+	return rest.CopyConfig(c.restConfig), nil
 }
 
 func (c *restClientGetter) ToDiscoveryClient() (discovery.CachedDiscoveryInterface, error) {

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ type restClientGetter struct {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`func (c restClientGetter) ToRESTConfig() (rest.Config, error) {`
`51`		`- return c.restConfig, nil`
	`51`	`+ return rest.CopyConfig(c.restConfig), nil`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`func (c *restClientGetter) ToDiscoveryClient() (discovery.CachedDiscoveryInterface, error) {`