Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE file rule shouldn't have required parameter that can be blank #155

Open
ethomson opened this issue Sep 9, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@ethomson
Copy link
Member

ethomson commented Sep 9, 2024

The license rule has the following configuration:

    properties:
      license_type:
        type: string
        description: |
          The license type to look for.
          For example, Apache, MIT, etc.
          Leave "" to only check for the presence of the license file.
    required:
      - license_filename
      - license_type

This field should not be required. Users should be able to omit the license_type and have it behave as if an empty string were specified.

This is especially important for programmatic parsing / understanding of this structure.

@ethomson ethomson added the bug Something isn't working label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant