feat(observability): add logs and traces retentions days (#1032)

* feat(observability): add logs and traces retentions days

* feat(observability): add inputs to acceptance test

* feat(observability): add inputs to example

* feat(observability): fix docs

* feat(observability): fix ModifyPlan checks after review

* feat(observability): fix acceptance test max values

* feat(observability): fix lint issues

* feat(observability): apply suggestion

Author: mitterle-sit

docs/data-sources/observability_instance.md

@@ -42,6 +42,7 @@ data "stackit_observability_instance" "example" {
 - `jaeger_traces_url` (String)
 - `jaeger_ui_url` (String)
 - `logs_push_url` (String) Specifies URL for pushing logs.
+- `logs_retention_days` (Number) Specifies for how many days the logs are kept. Default is set to `7`.
 - `logs_url` (String) Specifies Logs URL.
 - `metrics_push_url` (String) Specifies URL for pushing metrics.
 - `metrics_retention_days` (Number) Specifies for how many days the raw metrics are kept. Default is set to `90`.
@@ -54,6 +55,7 @@ data "stackit_observability_instance" "example" {
 - `plan_id` (String) The Observability plan ID.
 - `plan_name` (String) Specifies the Observability plan. E.g. `Observability-Monitoring-Medium-EU01`.
 - `targets_url` (String) Specifies Targets URL.
+- `traces_retention_days` (Number) Specifies for how many days the traces are kept. Default is set to `7`.
 - `zipkin_spans_url` (String)
 
 <a id="nestedatt--alert_config"></a>

docs/resources/observability_instance.md

@@ -16,8 +16,10 @@ Observability instance resource schema. Must have a `region` specified in the pr
 resource "stackit_observability_instance" "example" {
   project_id                             = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
   name                                   = "example-instance"
-  plan_name                              = "Observability-Monitoring-Medium-EU01"
+  plan_name                              = "Observability-Starter-EU01"
   acl                                    = ["1.1.1.1/32", "2.2.2.2/32"]
+  logs_retention_days                    = 30
+  traces_retention_days                  = 30
   metrics_retention_days                 = 90
   metrics_retention_days_5m_downsampling = 90
   metrics_retention_days_1h_downsampling = 90
@@ -43,10 +45,12 @@ import {
 
 - `acl` (Set of String) The access control list for this instance. Each entry is an IP address range that is permitted to access, in CIDR notation.
 - `alert_config` (Attributes) Alert configuration for the instance. (see [below for nested schema](#nestedatt--alert_config))
+- `logs_retention_days` (Number) Specifies for how many days the logs are kept. Default is set to `7`.
 - `metrics_retention_days` (Number) Specifies for how many days the raw metrics are kept. Default is set to `90`.
 - `metrics_retention_days_1h_downsampling` (Number) Specifies for how many days the 1h downsampled metrics are kept. must be less than the value of the 5m downsampling retention. Default is set to `90`.
 - `metrics_retention_days_5m_downsampling` (Number) Specifies for how many days the 5m downsampled metrics are kept. must be less than the value of the general retention. Default is set to `90`.
 - `parameters` (Map of String) Additional parameters.
+- `traces_retention_days` (Number) Specifies for how many days the traces are kept. Default is set to `7`.
 
 ### Read-Only
 

examples/resources/stackit_observability_instance/resource.tf

@@ -1,8 +1,10 @@
 resource "stackit_observability_instance" "example" {
   project_id                             = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
   name                                   = "example-instance"
-  plan_name                              = "Observability-Monitoring-Medium-EU01"
+  plan_name                              = "Observability-Starter-EU01"
   acl                                    = ["1.1.1.1/32", "2.2.2.2/32"]
+  logs_retention_days                    = 30
+  traces_retention_days                  = 30
   metrics_retention_days                 = 90
   metrics_retention_days_5m_downsampling = 90
   metrics_retention_days_1h_downsampling = 90

stackit/internal/services/observability/instance/datasource.go

@@ -132,6 +132,14 @@ func (d *instanceDataSource) Schema(_ context.Context, _ datasource.SchemaReques
 				Computed:    true,
 				Sensitive:   true,
 			},
+			"traces_retention_days": schema.Int64Attribute{
+				Description: "Specifies for how many days the traces are kept. Default is set to `7`.",
+				Computed:    true,
+			},
+			"logs_retention_days": schema.Int64Attribute{
+				Description: "Specifies for how many days the logs are kept. Default is set to `7`.",
+				Computed:    true,
+			},
 			"metrics_retention_days": schema.Int64Attribute{
 				Description: "Specifies for how many days the raw metrics are kept. Default is set to `90`.",
 				Computed:    true,
@@ -454,6 +462,44 @@ func (d *instanceDataSource) Read(ctx context.Context, req datasource.ReadReques
 		if resp.Diagnostics.HasError() {
 			return
 		}
+
+		// Handle Logs Retentions
+		logsRetentionResp, err := d.client.GetLogsConfigs(ctx, instanceId, projectId).Execute()
+		if err != nil {
+			core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading instance", fmt.Sprintf("Calling API to get logs retention: %v", err))
+			return
+		}
+
+		err = mapLogsRetentionField(logsRetentionResp, &model)
+		if err != nil {
+			core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading instance", fmt.Sprintf("Processing API response for the logs retention: %v", err))
+			return
+		}
+
+		diags = setLogsRetentions(ctx, &resp.State, &model)
+		resp.Diagnostics.Append(diags...)
+		if resp.Diagnostics.HasError() {
+			return
+		}
+
+		// Handle Traces Retentions
+		tracesRetentionResp, err := d.client.GetTracesConfigs(ctx, instanceId, projectId).Execute()
+		if err != nil {
+			core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading instance", fmt.Sprintf("Calling API to get traces retention: %v", err))
+			return
+		}
+
+		err = mapTracesRetentionField(tracesRetentionResp, &model)
+		if err != nil {
+			core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading instance", fmt.Sprintf("Processing API response for the traces retention: %v", err))
+			return
+		}
+
+		diags = setTracesRetentions(ctx, &resp.State, &model)
+		resp.Diagnostics.Append(diags...)
+		if resp.Diagnostics.HasError() {
+			return
+		}
 	}
 
 	// There are plans where no alert matchers and receivers are present e.g. like Observability-Metrics-Endpoint-100k-EU01